Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(snuba): Combine bootstrap & migrate for faster bootstrap #3491

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

BYK
Copy link
Member

@BYK BYK commented Dec 23, 2024

I think we split these actions in the past due to some lack of options for them to work together properly. Right now looks like bootstrap would automatically migrate and propagates the force flag.

I think we split these actions in the past due to some lack of options for them to work together properly. Right now looks like `bootstrap` would automatically migrate and propagates the `force` flag.
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.03%. Comparing base (4fa0833) to head (4661120).
Report is 3 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3491   +/-   ##
=======================================
  Coverage   99.03%   99.03%           
=======================================
  Files           3        3           
  Lines         207      207           
=======================================
  Hits          205      205           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BYK BYK marked this pull request as ready for review December 23, 2024 09:07
Copy link
Member

@hubertdeng123 hubertdeng123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems to be looking fine with this

@BYK BYK merged commit 282410a into master Dec 23, 2024
14 checks passed
@BYK BYK deleted the byk/ref/faster-snuba-bootstrap branch December 23, 2024 23:05
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants