-
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
============================================
- Coverage 58.27% 57.89% -0.38%
+ Complexity 573 567 -6
============================================
Files 72 72
Lines 2701 2691 -10
Branches 231 230 -1
============================================
- Hits 1574 1558 -16
- Misses 1016 1018 +2
- Partials 111 115 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@metlos hey :) would you have 2 cents to contribute here?
we aim to be fully thread-safe and guess our clone methods had race conditions, right now I'm using "reference assignment" as it's supposed to be atomic.
I've tried to implement a deep copy, but not sure if I'm happy with it yet.
Also I've changed ArrayList to the Concurrent ones.
Unfortunately, we cannot be fully immutable, so that makes a bit harder.
Thanks :)
📢 Type of change
📜 Description
clone race condition free.
💡 Motivation and Context
because the clone methods might give some race conditions.
💚 How did you test it?
just ran the tests.
📝 Checklist
🔮 Next steps