Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

do not set frames if there's none #234

Merged
merged 1 commit into from
Jan 16, 2020
Merged

do not set frames if there's none #234

merged 1 commit into from
Jan 16, 2020

Conversation

marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

do not set frames if there's none.

💡 Motivation and Context

fix #233

💚 How did you test it?

unit test.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

codecov-io commented Jan 16, 2020

Codecov Report

Merging #234 into master will increase coverage by 0.06%.
The diff coverage is 92.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #234      +/-   ##
============================================
+ Coverage     58.76%   58.82%   +0.06%     
- Complexity      569      572       +3     
============================================
  Files            72       72              
  Lines          2653     2657       +4     
  Branches        235      236       +1     
============================================
+ Hits           1559     1563       +4     
  Misses          979      979              
  Partials        115      115
Impacted Files Coverage Δ Complexity Δ
...n/java/io/sentry/core/SentryStackTraceFactory.java 90.9% <100%> (+0.28%) 13 <5> (+1) ⬆️
...in/java/io/sentry/core/SentryExceptionFactory.java 92.68% <88.88%> (ø) 8 <6> (ø) ⬇️
.../main/java/io/sentry/core/SentryThreadFactory.java 96.29% <92.85%> (-3.71%) 9 <8> (+1)
...c/main/java/io/sentry/core/DirectoryProcessor.java 80% <0%> (+4%) 7% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5872731...532fa0f. Read the comment docs.

@marandaneto marandaneto merged commit f6b8292 into master Jan 16, 2020
@marandaneto marandaneto deleted the fix/empty_frames branch January 16, 2020 11:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There were 5 errors encountered while processing this event
3 participants