Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

few improvements identified by a pre-release list #237

Merged
merged 1 commit into from
Jan 16, 2020

Conversation

marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

few improvements identified by a pre-release list.

💡 Motivation and Context

to meet the unified API.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@@ -93,6 +94,8 @@ void addBreadcrumb(@NotNull Breadcrumb breadcrumb, boolean executeBeforeBreadcru
}

if (breadcrumb == null) {
// options.getLogger().log(SentryLevel.INFO, "Breadcrumb was dropped by scope
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds fair to have this log. Perhaps in Debug mode instead?
Or remove dead code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually we don't have access to options object on this class, that's why, it's a TODO.
I'll try to fix this "workaround" with the Scope class and Before BreadCrumb before GA, it's a design flaw.

@codecov-io
Copy link

codecov-io commented Jan 16, 2020

Codecov Report

Merging #237 into master will decrease coverage by 0.35%.
The diff coverage is 40.9%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #237      +/-   ##
============================================
- Coverage     58.81%   58.46%   -0.36%     
- Complexity      571      573       +2     
============================================
  Files            72       72              
  Lines          2659     2699      +40     
  Branches        235      237       +2     
============================================
+ Hits           1564     1578      +14     
- Misses          980     1006      +26     
  Partials        115      115
Impacted Files Coverage Δ Complexity Δ
...core/src/main/java/io/sentry/core/SentryEvent.java 61.6% <0%> (-8.09%) 40 <0> (ø)
...entry-core/src/main/java/io/sentry/core/Scope.java 75.51% <0%> (-11.55%) 30 <0> (ø)
sentry-core/src/main/java/io/sentry/core/Dsn.java 94.11% <100%> (ø) 12 <7> (ø) ⬇️
...re/src/main/java/io/sentry/core/SentryOptions.java 78.22% <100%> (ø) 55 <0> (ø) ⬇️
...n/java/io/sentry/core/transport/HttpTransport.java 59.75% <100%> (ø) 6 <0> (ø) ⬇️
sentry-core/src/main/java/io/sentry/core/Hub.java 70.24% <100%> (+0.1%) 55 <0> (ø) ⬇️
...ore/src/main/java/io/sentry/core/SentryClient.java 89.34% <100%> (+1.27%) 35 <0> (+2) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6b8292...c754c36. Read the comment docs.

@marandaneto marandaneto merged commit 7ddcc88 into master Jan 16, 2020
@marandaneto marandaneto deleted the fix/prerelease_list branch January 16, 2020 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants