Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Add tests for SentryValues #238

Merged
merged 1 commit into from
Jan 17, 2020
Merged

Add tests for SentryValues #238

merged 1 commit into from
Jan 17, 2020

Conversation

philipphofmann
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Add tests for SentryValues to raise its code coverage to 100%.

💡 Motivation and Context

Easier to change SentryValues.

💚 How did you test it?

With running the unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

Codecov Report

Merging #238 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #238      +/-   ##
============================================
+ Coverage     58.46%   58.54%   +0.07%     
- Complexity      573      574       +1     
============================================
  Files            72       72              
  Lines          2699     2699              
  Branches        237      237              
============================================
+ Hits           1578     1580       +2     
+ Misses         1006     1005       -1     
+ Partials        115      114       -1
Impacted Files Coverage Δ Complexity Δ
...ore/src/main/java/io/sentry/core/SentryValues.java 100% <0%> (+33.33%) 3% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ddcc88...0c149cb. Read the comment docs.

@bruno-garcia
Copy link
Member

Thanks @philipphofmann

@bruno-garcia bruno-garcia merged commit 30ed922 into getsentry:master Jan 17, 2020
@philipphofmann philipphofmann deleted the ref/sentryvalues_tests branch January 17, 2020 17:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants