This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
moving back ANR timeout from long to int param. #252
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
moving back ANR timeout from long to int param..
💡 Motivation and Context
as a long, it was gonna require that users set value with an "l" or "L" at the end, like 1000l, and might cause a lot of noise to us on support, so a normal int would be fine and we convert it to long.
how it is:
<meta-data android:name="io.sentry.anr.timeout-interval-mills" android:value="1000l" />
how it's gonna be:
<meta-data android:name="io.sentry.anr.timeout-interval-mills" android:value="1000" />
💚 How did you test it?
ran unit tests.
📝 Checklist
🔮 Next steps