Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

moving back ANR timeout from long to int param. #252

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Jan 28, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

moving back ANR timeout from long to int param..

💡 Motivation and Context

as a long, it was gonna require that users set value with an "l" or "L" at the end, like 1000l, and might cause a lot of noise to us on support, so a normal int would be fine and we convert it to long.
how it is:
<meta-data android:name="io.sentry.anr.timeout-interval-mills" android:value="1000l" />

how it's gonna be:
<meta-data android:name="io.sentry.anr.timeout-interval-mills" android:value="1000" />

💚 How did you test it?

ran unit tests.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

Codecov Report

Merging #252 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #252   +/-   ##
=========================================
  Coverage     57.26%   57.26%           
  Complexity      576      576           
=========================================
  Files            73       73           
  Lines          2761     2761           
  Branches        234      234           
=========================================
  Hits           1581     1581           
  Misses         1062     1062           
  Partials        118      118

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 767be35...02c9bed. Read the comment docs.

@marandaneto marandaneto merged commit 0a116e0 into master Jan 28, 2020
@marandaneto marandaneto deleted the fix/anr_param branch January 28, 2020 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants