Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Support mills timestamp format #263

Merged
merged 2 commits into from
Feb 11, 2020
Merged

Conversation

marandaneto
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Support mills timestamp format.
eg 1581410911.988
which is {seconds}.{mills}

💡 Motivation and Context

JS sends mills timestamp format and we need to support hybrid SDKs.

💚 How did you test it?

unit test.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

🔮 Next steps

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@29fdaaf). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #263   +/-   ##
=========================================
  Coverage          ?   57.13%           
  Complexity        ?      576           
=========================================
  Files             ?       73           
  Lines             ?     2767           
  Branches          ?      235           
=========================================
  Hits              ?     1581           
  Misses            ?     1068           
  Partials          ?      118
Impacted Files Coverage Δ Complexity Δ
...y-core/src/main/java/io/sentry/core/DateUtils.java 55.55% <0%> (ø) 4 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29fdaaf...fecdf93. Read the comment docs.

@marandaneto marandaneto requested a review from HazAT February 11, 2020 13:21
@marandaneto marandaneto merged commit 48c23d1 into master Feb 11, 2020
@marandaneto marandaneto deleted the enha/support_mills_timestamp branch February 11, 2020 14:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants