Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

fix: preview package manager #269

Merged
merged 1 commit into from
Feb 17, 2020
Merged

fix: preview package manager #269

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,10 +227,10 @@ private SdkVersion getSdkVersion() {
sdkVersion.setName("sentry.java.android");
String version = BuildConfig.VERSION_NAME;
sdkVersion.setVersion(version);
sdkVersion.addPackage("sentry-core", version);
sdkVersion.addPackage("sentry-android-core", version);
sdkVersion.addPackage("maven:sentry-core", version);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so it's missing maven:sentry-android here, right? I remember asking it but not sure why

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, yes we are

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, we don't know though. It's missing only if it was installed. Which we don't know here, do we? How can we figure out if that package was added? Maybe meta-data merging?

Copy link
Contributor

@marandaneto marandaneto Feb 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could through reflection or adding something to manifest and check it on runtime or the backend side does the grouping and will know if android-core and android-ndk are there, but yes on the client side would be easier and less error-prone.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, will raise for that

sdkVersion.addPackage("maven:sentry-android-core", version);
if (options.isEnableNdk()) {
sdkVersion.addPackage("sentry-android-ndk", version);
sdkVersion.addPackage("maven:sentry-android-ndk", version);
}

return sdkVersion;
Expand Down