Skip to content
This repository has been archived by the owner on Aug 30, 2023. It is now read-only.

Add the default serverName to SentryOptions and use it in MainEventProcessor #279

Merged
merged 1 commit into from
Feb 24, 2020

Conversation

metlos
Copy link
Contributor

@metlos metlos commented Feb 23, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This adds support for the default server name specified in sentry options so that it can be used in events.

💡 Motivation and Context

This feature exists in sentry-java and is a documented Sentry option, e.g. https://docs.sentry.io/error-reporting/configuration/?platform=csharp#server-name

💚 How did you test it?

Updated the unit tests of the MainEventProcessor to test that the option is applied.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • All tests passing

@codecov-io
Copy link

Codecov Report

Merging #279 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #279      +/-   ##
============================================
+ Coverage      57.3%   57.49%   +0.18%     
- Complexity      582      587       +5     
============================================
  Files            73       73              
  Lines          2785     2790       +5     
  Branches        235      236       +1     
============================================
+ Hits           1596     1604       +8     
+ Misses         1072     1069       -3     
  Partials        117      117
Impacted Files Coverage Δ Complexity Δ
...c/main/java/io/sentry/core/MainEventProcessor.java 76.31% <100%> (+1.31%) 10 <0> (+1) ⬆️
...re/src/main/java/io/sentry/core/SentryOptions.java 79.67% <100%> (+0.5%) 60 <2> (+2) ⬆️
...core/src/main/java/io/sentry/core/SentryEvent.java 64.28% <0%> (+2.67%) 42% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3785de...29ac590. Read the comment docs.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bruno-garcia bruno-garcia merged commit bf29a57 into getsentry:master Feb 24, 2020
@metlos metlos deleted the add-servername-to-options branch February 24, 2020 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants