This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bruno-garcia
approved these changes
Mar 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raised a question otherwise LGTM
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
============================================
- Coverage 59.01% 58.98% -0.03%
+ Complexity 761 760 -1
============================================
Files 86 86
Lines 3523 3523
Branches 339 339
============================================
- Hits 2079 2078 -1
Misses 1295 1295
- Partials 149 150 +1
Continue to review full report at Codecov.
|
marandaneto
changed the title
update sentry-native to 0.2.1
update sentry-native to 0.2.2
Mar 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Update the
sentry-native
submodule to version0.2.1
, which has important fixes for the module finder (fallback for libs without build-id) and a lot of other fixes overall.💡 Motivation and Context
💚 How did you test it?
ran the example
📝 Checklist
🔮 Next steps