This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
============================================
- Coverage 58.8% 58.78% -0.03%
- Complexity 743 757 +14
============================================
Files 85 87 +2
Lines 3520 3530 +10
Branches 330 333 +3
============================================
+ Hits 2070 2075 +5
- Misses 1299 1302 +3
- Partials 151 153 +2
Continue to review full report at Codecov.
|
7 tasks
bruno-garcia
suggested changes
Mar 25, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few points for us to discuss
sentry-android-core/src/main/java/io/sentry/android/core/EnvelopeFileObserver.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/EnvelopeFileObserver.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/EnvelopeFileObserver.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/EnvelopeFileObserver.java
Outdated
Show resolved
Hide resolved
sentry-core/src/main/java/io/sentry/core/MainEventProcessor.java
Outdated
Show resolved
Hide resolved
sentry-core/src/main/java/io/sentry/core/hints/CachedEnvelopeHint.java
Outdated
Show resolved
Hide resolved
bruno-garcia
approved these changes
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
ndk events apply scoped data.
💡 Motivation and Context
right now ndk events never apply scoped data, but it should.
fix #291
💚 How did you test it?
CI, tests
📝 Checklist
🔮 Next steps