This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
feat: timber integration #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marandaneto
commented
Jun 18, 2020
sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt
Outdated
Show resolved
Hide resolved
marandaneto
commented
Jun 18, 2020
| // let's take only the 1st line as this is probably the only message written by the user. | ||
| // or the 1st line of the exception which is probably the same as event.title | ||
| // eg java.lang.Exception: java.lang.Exception: java.lang.Exception: Some exception. | ||
| // timber should offer a way of disabling it |
There was a problem hiding this comment.
sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberIntegration.kt
Outdated
Show resolved
Hide resolved
sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberIntegration.kt
Show resolved
Hide resolved
| import kotlin.test.assertEquals | ||
| import timber.log.Timber | ||
|
|
||
| class SentryTimberIntegrationTest { |
There was a problem hiding this comment.
m: It would be nice to have an integration test for testing the whole integration with our SDK. Checking if running the following code and then logging via timber actually passes the timber events to our SDK.
SentryAndroid.init(
this,
options -> {
options.addIntegration(new SentryTimberIntegration());
});
There was a problem hiding this comment.
mm it's possible, but we don't do this for any other integration I guess, as what really matters is the Hub to be called and this is already tested -> SentryTimberTreeTest
I'll check that though
sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt
Outdated
Show resolved
Hide resolved
sentry-android-timber/src/test/java/io/sentry/android/timber/SentryTimberTreeTest.kt
Show resolved
Hide resolved
sentry-android-timber/src/test/java/io/sentry/android/timber/SentryTimberTreeTest.kt
Show resolved
Hide resolved
bruno-garcia
suggested changes
Jun 23, 2020
sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt
Show resolved
Hide resolved
sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt
Outdated
Show resolved
Hide resolved
sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt
Outdated
Show resolved
Hide resolved
sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberTree.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
feat: timber integration
💡 Motivation and Context
one may raise events from Timber
💚 How did you test it?
running and unit tests
📝 Checklist
🔮 Next steps
revert manifest and self init, but we need to define the sample somewhere