This repository has been archived by the owner on Aug 30, 2023. It is now read-only.
fix: envelope header has sdkVersion and not sdkInfo #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/AndroidOptionsInitializerTest.kt
Outdated
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/AndroidOptionsInitializerTest.kt
Show resolved
Hide resolved
sentry-android-core/src/test/java/io/sentry/android/core/AndroidSerializerTest.kt
Outdated
Show resolved
Hide resolved
sentry-android-timber/src/main/java/io/sentry/android/timber/SentryTimberIntegration.kt
Outdated
Show resolved
Hide resolved
sentry-android-ndk/src/main/java/io/sentry/android/ndk/SentryNdk.java
Outdated
Show resolved
Hide resolved
sentry-core/src/main/java/io/sentry/core/SentryEnvelopeHeaderAdapter.java
Show resolved
Hide resolved
sentry-core/src/main/java/io/sentry/core/SentryEnvelopeHeaderAdapter.java
Show resolved
Hide resolved
sentry-core/src/main/java/io/sentry/core/SentryEnvelopeHeaderAdapter.java
Outdated
Show resolved
Hide resolved
Comment on lines
+50
to
+51
| // TODO: sentry-core should add itself as the version may mismatch | ||
| sdkVersion.addPackage("maven:sentry-core", version); |
There was a problem hiding this comment.
Created issue to follow up: https://github.com/getsentry/sentry-java/projects/1#card-42202340
philipphofmann
approved these changes
Jul 21, 2020
sentry-android-ndk/src/test/java/io/sentry/android/ndk/SentryNdkUtilTest.kt
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
fix: envelope header has sdkVersion and not sdkInfo
💡 Motivation and Context
getsentry/develop#89
docs were wrong about which object to use
💚 How did you test it?
📝 Checklist
🔮 Next steps