Set SdkVersion in default SentryOptions created in sentry-core module

buildSrc/src/main/java/Config.kt

@@ -5,6 +5,8 @@ object Config {
     object BuildPlugins {
         val androidGradle = "com.android.tools.build:gradle:4.0.1"
         val kotlinGradlePlugin = "gradle-plugin"
+        val buildConfig = "com.github.gmazzo.buildconfig"
+        val buildConfigVersion = "2.0.2"
     }
 
     object Android {
@@ -58,7 +60,8 @@ object Config {
     }
 
     object Sentry {
-        val SENTRY_CLIENT_NAME = "sentry.java.android"
+        val SENTRY_CLIENT_NAME = "sentry.java"
+        val SENTRY_ANDROID_CLIENT_NAME = "$SENTRY_CLIENT_NAME.android"
         val group = "io.sentry"
         val description = "SDK for sentry.io"
         val website = "https://sentry.io"

sentry-android-core/build.gradle.kts

@@ -23,7 +23,7 @@ android {
         versionName = project.version.toString()
         versionCode = project.properties[Config.Sentry.buildVersionCodeProp].toString().toInt()
 
-        buildConfigField("String", "SENTRY_CLIENT_NAME", "\"${Config.Sentry.SENTRY_CLIENT_NAME}\"")
+        buildConfigField("String", "SENTRY_CLIENT_NAME", "\"${Config.Sentry.SENTRY_ANDROID_CLIENT_NAME}\"")
     }
 
     buildTypes {

sentry-android-core/src/main/java/io/sentry/android/core/SentryAndroidOptions.java

@@ -40,16 +40,16 @@ public SentryAndroidOptions() {
   }
 
   private @NotNull SdkVersion createSdkVersion() {
-    final SdkVersion sdkVersion = new SdkVersion();
+    SdkVersion sdkVersion = getSdkVersion();
+
+    if (sdkVersion == null) {
+      sdkVersion = new SdkVersion();
+    }
 
     sdkVersion.setName(BuildConfig.SENTRY_CLIENT_NAME);
     String version = BuildConfig.VERSION_NAME;
     sdkVersion.setVersion(version);
-
-    // add 2 default packages
     sdkVersion.addPackage("maven:sentry-android-core", version);
-    // TODO: sentry-core should add itself as the version may mismatch
-    sdkVersion.addPackage("maven:sentry-core", version);
 
     return sdkVersion;
   }

sentry-android-core/src/test/java/io/sentry/android/core/SentryAndroidOptionsTest.kt

@@ -26,12 +26,12 @@ class SentryAndroidOptionsTest {
         assertEquals(BuildConfig.VERSION_NAME, sdkVersion.version)
 
         assertTrue(sdkVersion.packages!!.any {
-            it.name == "maven:sentry-android-core"
+            it.name == "maven:sentry-android-core" &&
             it.version == BuildConfig.VERSION_NAME
         })
 
         assertTrue(sdkVersion.packages!!.any {
-            it.name == "maven:sentry-core"
+            it.name == "maven:sentry-core" &&
             it.version == BuildConfig.VERSION_NAME
         })
     }

sentry-android-ndk/src/test/java/io/sentry/android/ndk/SentryNdkUtilTest.kt

@@ -1,7 +1,6 @@
 package io.sentry.android.ndk
 
 import io.sentry.core.SentryOptions
-import io.sentry.core.protocol.SdkVersion
 import kotlin.test.Test
 import kotlin.test.assertNull
 import kotlin.test.assertTrue
@@ -10,9 +9,7 @@ class SentryNdkUtilTest {
 
     @Test
     fun `SentryNdk adds the Ndk package into the package list`() {
-        val options = SentryOptions().apply {
-            sdkVersion = SdkVersion()
-        }
+        val options = SentryOptions()
         SentryNdkUtil.addPackage(options.sdkVersion)
         assertTrue(options.sdkVersion!!.packages!!.any {
             it.name == "maven:sentry-android-ndk"
@@ -22,7 +19,9 @@ class SentryNdkUtilTest {
 
     @Test
     fun `SentryNdk do not add the Ndk package into the package list`() {
-        val options = SentryOptions()
+        val options = SentryOptions().apply {
+            sdkVersion = null
+        }
         SentryNdkUtil.addPackage(options.sdkVersion)
 
         assertNull(options.sdkVersion?.packages)

sentry-core/build.gradle.kts

@@ -7,6 +7,7 @@ plugins {
     id(Config.QualityPlugins.errorProne)
     id(Config.Deploy.novodaBintray)
     id(Config.QualityPlugins.gradleVersions)
+    id(Config.BuildPlugins.buildConfig) version Config.BuildPlugins.buildConfigVersion
 }
 
 configure<JavaPluginConvention> {
@@ -65,6 +66,18 @@ tasks {
     }
 }
 
+buildConfig {
+    useJavaOutput()
+    packageName("io.sentry.core")
+    buildConfigField("String", "SDK_NAME", "\"${Config.Sentry.SENTRY_CLIENT_NAME}\"")
+    buildConfigField("String", "SDK_VERSION", "\"${project.version}\"")
+}
+
+val generateBuildConfig by tasks
+tasks.withType<JavaCompile>().configureEach {
+    dependsOn(generateBuildConfig)
+}
+
 //TODO: move thse blocks to parent gradle file, DRY
 configure<PublishExtension> {
     userOrg = Config.Sentry.userOrg

sentry-core/src/main/java/io/sentry/core/SentryOptions.java

@@ -1036,5 +1036,18 @@ public SentryOptions() {
     integrations.add(new ShutdownHookIntegration());
 
     eventProcessors.add(new MainEventProcessor(this));
+
+    setSdkVersion(createSdkVersion());
+  }
+
+  private @NotNull SdkVersion createSdkVersion() {
+    final SdkVersion sdkVersion = new SdkVersion();
+
+    sdkVersion.setName(BuildConfig.SDK_NAME);
+    String version = BuildConfig.SDK_VERSION;
+    sdkVersion.setVersion(version);
+    sdkVersion.addPackage("maven:sentry-core", version);
+
+    return sdkVersion;
   }
 }

sentry-core/src/test/java/io/sentry/core/SentryOptionsTest.kt

@@ -124,4 +124,19 @@ class SentryOptionsTest {
         val options = SentryOptions()
         assertNotNull(options.executorService)
     }
+
+    @Test
+    fun `init should set SdkVersion`() {
+        val sentryOptions = SentryOptions()
+        assertNotNull(sentryOptions.sdkVersion)
+        val sdkVersion = sentryOptions.sdkVersion!!
+
+        assertEquals(BuildConfig.SDK_NAME, sdkVersion.name)
+        assertEquals(BuildConfig.SDK_VERSION, sdkVersion.version)
+
+        assertTrue(sdkVersion.packages!!.any {
+            it.name == "maven:sentry-core" &&
+            it.version == BuildConfig.SDK_VERSION
+        })
+    }
 }