scripts/check-siblings: Update to work with yarn patch. #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`yarn patch` changes the version to something like this: `patch:@sentry/nextjs@npm%3A8.27.0#~/.yarn/patches/@sentry-nextjs-npm-8.27.0-0e3a1ce4c2.patch` This means that exact version `8.27.0` was used as base and patched.
Shayan-To
commented
Nov 5, 2024
| @@ -68,7 +68,7 @@ function ValidateSentryPackageParameters(packages) { | |||
| if (installedVersion.split('@').length === 2) { | |||
| errorMessages.push("You must specify the version to the package " + installedVersion + ". ( " + installedVersion + "@" + siblingVersion + ")"); | |||
| } | |||
| else if (!installedVersion.endsWith(siblingVersion)) { | |||
| else if (!installedVersion.endsWith(siblingVersion) && !installedVersion.includes('%3A' + siblingVersion + '#')) { | |||
There was a problem hiding this comment.
I'm not sure if this is correct. I'm using yarn 4.3.1, and it's not setting npm_config_argv environment variable, and I don't know the exact syntax of it.
|
Looks good to me ! Thank you for the contribution! |
lucas-zimerman
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using
@sentry/nextjsversion8.27.0, and I cannot update to the latest version because of a bug introduced in the next version. And there was another bug on8.27.0. So I had to useyarn patchto fix the latter mentioned bug without updating the package.yarn patchchanges the version to something like this:patch:@sentry/nextjs@npm%3A8.27.0#~/.yarn/patches/@sentry-nextjs-npm-8.27.0-0e3a1ce4c2.patchThis means that exact version8.27.0was used as base and patched.This PR updates the sibling version check to work with
yarn patchversions.#skip-changelog