Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: normalize test #805

Merged

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Dec 10, 2024

PR Aimed to fix the normalized tests that started to fail on the latest JavaScript SDK.

#skip-changelog.

@lucas-zimerman lucas-zimerman changed the base branch from main to deps/scripts/update-javascript-siblings.sh December 10, 2024 12:11
@lucas-zimerman lucas-zimerman requested review from 0Calories and krystofwoldrich and removed request for 0Calories December 10, 2024 12:13
@lucas-zimerman lucas-zimerman marked this pull request as ready for review December 10, 2024 12:22
@lucas-zimerman lucas-zimerman changed the title Fix/normalize test Fix: normalize test Dec 10, 2024
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@lucas-zimerman lucas-zimerman merged commit d3c6abd into deps/scripts/update-javascript-siblings.sh Dec 17, 2024
20 checks passed
@lucas-zimerman lucas-zimerman deleted the fix/normalize-test branch December 17, 2024 15:53
lucas-zimerman added a commit that referenced this pull request Jan 6, 2025
* chore: update scripts/update-javascript-siblings.sh to 8.42.0

* change utils to core and fix code. update changelog

* test samples

* fix normalize test (#805)

* Update CHANGELOG.md

---------

Co-authored-by: GitHub <noreply@github.com>
Co-authored-by: lucas <lucas-zimerman1@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants