feat(api): Validate monitors run command's --timezone argument (#…

…1847)

The `sentry-cli monitors run` command's `--timezone` argument will now be validated against a list of valid IANA time zone database identifiers. If the user provides a `--timezone` argument, which does not match a valid IANA time zone identifier, the command will fail with an error. Previously, the command would appear to run successfully, but the monitor upsert would silently fail in the Sentry backend, since the backend rejects monitor upserts that have an invalid timezone string.

Fixes GH-1845

Cargo.toml

@@ -14,7 +14,7 @@ backtrace = "0.3.67"
 brotli2 = "0.3.2"
 bytecount = "0.6.3"
 chardet = "0.2.4"
-chrono = { version = "0.4.23", features = ["serde"] }
+chrono = { version = "0.4.31", features = ["serde"] }
 clap = { version = "4.1.6", default-features = false, features = [
   "std",
   "suggestions",
@@ -77,6 +77,7 @@ which = "4.4.0"
 zip = "0.6.4"
 data-encoding = "2.3.3"
 magic_string = "0.3.4"
+chrono-tz = "0.8.4"
 
 [dev-dependencies]
 insta = { version = "1.26.0", features = ["redactions", "yaml"] }

src/commands/monitors/run.rs

@@ -1,3 +1,4 @@
+use chrono_tz::Tz;
 use log::warn;
 use std::process;
 use std::time::{Duration, Instant};
@@ -73,10 +74,16 @@ pub fn make_command(command: Command) -> Command {
         .arg(
             Arg::new("timezone")
                 .long("timezone")
+                .value_parser(|value: &str| {
+                    value.parse::<Tz>().map_err(|err| {
+                        err + "\n\tSee here for a list of valid timezone strings: \
+                            https://en.wikipedia.org/wiki/List_of_tz_database_time_zones#List"
+                    })
+                })
                 .requires("schedule")
                 .help(
                     "A tz database string (e.g. \"Europe/Vienna\") representing the monitor's \
-             execution schedule's timezone. Requires --schedule.",
+                    execution schedule's timezone. Requires --schedule.",
                 ),
         )
 }
@@ -202,7 +209,7 @@ fn parse_monitor_config_args(matches: &ArgMatches) -> Result<Option<MonitorConfi
         schedule,
         checkin_margin: matches.get_one("checkin_margin").copied(),
         max_runtime: matches.get_one("max_runtime").copied(),
-        timezone: matches.get_one("timezone").cloned(),
+        timezone: matches.get_one("timezone").map(Tz::to_string),
     }))
 }