Skip to content

feat(profiling): add profiling to debug_files commands #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

feat(profiling): add profiling to debug_files commands #1325

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
56baa60
Add profiling
viglia Sep 7, 2022
92de5cb
Lower the traces_sample_rate to 0.01
viglia Sep 13, 2022
60f1e22
Fix formatting
viglia Sep 13, 2022
d5ea8e0
Pass SENTRY_DSN env variable to Lint job
viglia Sep 13, 2022
ee45b8a
Fix build.yml and ci.yml
viglia Sep 13, 2022
ef44cbb
Set traces_sample_rate to 5%
viglia Sep 13, 2022
1f6a18a
Fix org and project name
viglia Sep 22, 2022
2259fb1
Wraps command in a closure to make sure the transaction ends regardle…
viglia Sep 23, 2022
29fc3a5
Makes profiling integration optional
viglia Sep 23, 2022
e1ba397
Fixes yaml linting error
viglia Sep 23, 2022
d8f7114
Revert execute functions.
viglia Sep 27, 2022
e68b3f7
Customize error message in case SENTRY_DSN env variable is missing
viglia Sep 27, 2022
e64e60c
Formatting with cargo fmt
viglia Sep 27, 2022
eef84e1
Reverts to the shortcut [target."cfg(unix)".dependencies]
viglia Sep 27, 2022
5656e6e
Run cargo update
viglia Sep 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 35 additions & 4 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,20 @@ jobs:
env:
TARGET: ${{ matrix.target }}
DOCKER_TAG: ${{ matrix.container }}
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}


- name: Rename Binary
run: mv target/*/release/sentry-cli sentry-cli-Linux-${{ matrix.arch }}

- name: Upload Symbols
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
run: sentry-cli-Linux-${{ matrix.arch }} upload-dif sentry-cli-Linux-${{ matrix.arch }} --org sentry --project sentry-cli

- name: Strip Symbols from Binary
run: strip sentry-cli-Linux-${{ matrix.arch }}

- uses: actions/upload-artifact@v2
with:
name: ${{ github.sha }}
Expand Down Expand Up @@ -68,16 +78,35 @@ jobs:
target: ${{ matrix.target }}
profile: minimal
override: true
components: rust-src

- name: Run Cargo Build
uses: actions-rs/cargo@v1
- name: Install Nightly Toolchain
uses: actions-rs/toolchain@v1
with:
command: build
args: --target=${{ matrix.target }} --release --locked
toolchain: nightly
target: ${{ matrix.target }}
profile: minimal
components: rust-src

- name: Build with Frame Pointer
env:
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
shell: bash
run: |
cargo +nightly run -Z build-std --target ${{ matrix.target }}
RUSTFLAGS="-C force-frame-pointers=yes" cargo build --release --target=${{ matrix.target }} --features "profiling" --locked

- name: Rename Binary
run: mv target/${{ matrix.target }}/release/sentry-cli sentry-cli-Darwin-${{ matrix.arch }}

- name: Upload Symbols
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
run: sentry-cli-Darwin-${{ matrix.arch }} upload-dif sentry-cli-Darwin-${{ matrix.arch }} --org sentry --project sentry-cli

- name: Strip Symbols from Binary
run: strip sentry-cli-Darwin-${{ matrix.arch }}

- uses: actions/upload-artifact@v2
with:
name: ${{ github.sha }}
Expand Down Expand Up @@ -127,6 +156,8 @@ jobs:

- name: Run Cargo Build
uses: actions-rs/cargo@v1
env:
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
with:
command: build
args: --release --locked
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ jobs:

- name: Run Clippy
uses: actions-rs/cargo@v1
env:
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
with:
command: clippy
args: --workspace --all-features --tests -- -D clippy::all
Expand Down Expand Up @@ -66,6 +68,8 @@ jobs:

- name: Run Cargo Tests
uses: actions-rs/cargo@v1
env:
SENTRY_DSN: ${{ secrets.SENTRY_DSN }}
with:
command: test
args: --all
Expand Down
Loading