Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(python): Stop building Python package #1972

Closed
wants to merge 1 commit into from

Conversation

szokeasaurusrex
Copy link
Member

We no longer release a Python package (see #1938 and #1779) because attempting to release for Python caused the release to fail.

However, I noticed that we are still building a Python package, which seems pointless since we don't release the Python package anywhere.

This PR disables Python package builds, and also deletes files that were only needed for the Python builds/packaging. If we ever re-enable Python releases, we would need to revert this PR.

@@ -167,49 +167,6 @@ jobs:
name: ${{ github.sha }}
path: '*.tgz'

python-base:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sentry and getsentry are using this -- could you please restore the python package?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile-sentry Craft fails whenever we attempt to release the Python package (see #1938). I think we tried upgrading the Debian version we use in Craft to fix this, but that broke something else (JS releases, I think).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was unaware though that we use the Python package in sentry and getsentry – we should probably prioritize looking into coming up with a fix in Craft then so we can start making Python releases

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @vaind found the cause of the node20 upgrade breaking things -- but looks like they didn't push through with fixing it getsentry/craft#518

Copy link
Member Author

@szokeasaurusrex szokeasaurusrex Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asottile-sentry Making sure I understood correctly: based on your comment, it sounds like we know the cause of the problem but it is not fixed yet, correct? I am confused because the issue you linked is closed.

Should I open a new issue in Craft about Sentry CLI Python releases being broken, or should we just reopen the getsentry/craft#518 and perhaps add a comment to mention that the issue is blocking Python releases?

@doc-sheet
Copy link

That's sad. Did you consider external retry logic like pypa/twine#1017 (comment) this one?

@szokeasaurusrex
Copy link
Member Author

Based on @asottile-sentry's comment above, we are going to try reenabling Python package releases

@szokeasaurusrex
Copy link
Member Author

@asottile-sentry @doc-sheet, looks like Python releases are working again after #1980!

https://pypi.org/project/sentry-cli/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants