Refactor deploys #2161
Merged
Refactor deploys #2161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/deploy-refactor
branch
from
7bf2b6b
to
58a0e42
Compare
loewenheim
approved these changes
Sep 20, 2024
We are using owned `String` types in this struct, where using `Cow<str>` would allow us to avoid allocations when constructing `Deploy`s in the `deploy new` command. We use `Cow<str>` rather than `&str` because `Deploy` needs to satisfy `DeserializeOwned`.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/deploy-refactor
branch
from
58a0e42
to
83d2465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cow<str>rather thanStringin theDeploystruct to avoid allocations where unnecessaryDeploystruct into separate moduleI have split this PR into two commits which separately implement each of the above changes. It might be easier to review the commits individually.
ref #2077