Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(windows): Statically link CRT on Windows #2203

Merged
merged 1 commit into from
Oct 30, 2024
Merged

build(windows): Statically link CRT on Windows #2203

merged 1 commit into from
Oct 30, 2024

Conversation

szokeasaurusrex
Copy link
Member

Statically link the CRT on Windows. This eliminates Sentry CLI's dependency on VCRUNTIME140.dll, allowing Sentry CLI to be run on a clean install of Windows, without requiring any external dependencies.

Fixes #2193
Closes #2201

@szokeasaurusrex
build(windows): Statically link CRT on Windows
394a155 
Statically link the CRT on Windows. This eliminates Sentry CLI's dependency on `VCRUNTIME140.dll`, allowing Sentry CLI to be run on a clean install of Windows, without requiring any external dependencies.

Fixes #2193
Closes #2201
@szokeasaurusrex szokeasaurusrex merged commit 69fe89f into master Oct 30, 2024
14 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/windows-static-link branch October 30, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dav1dde Dav1dde Dav1dde approved these changes

@loewenheim loewenheim Awaiting requested review from loewenheim

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Statically link Windows C Libraries command failed !! when webpack/sentry upload sourcemap ...
2 participants
@szokeasaurusrex @Dav1dde