fix: fixes org not being parsed for subcommands

[someguynamedmatt]

Relates to Issue #723

Following the docs for creating a new release was giving errors despite passing in the requested org command-line arg. I (think I) tracked it down to new not expecting the organization in its argument parsing despite searching for it on invocation.

[jan-auer]

Thank @someguynamedmatt, I'm afraid this fix duplicates the org argument, however. clap has a global flag on arguments, which would usually be used for this. I believe that in releases, we can set the org argument to global(true).

Edit: I hadn't looked at the code, of course the flag would go here:

sentry-cli/src/utils/args.rs

Line 111 in 75847f4

clap::Arg::with_name("org")

Some background: The reason we did not do this initially is that we wanted to keep it consistent between --org and --project. For --project, this does not work, since the -p shorthand is reused between commands where sometimes multiple projects are allowed, and sometimes only one.

[someguynamedmatt]

@jan-auer Updated. Thanks for looking at this. I've changed the code slightly to check the top-level command first then recursively checking the subcommands for the org value.

[jan-auer]

I've changed the code slightly to check the top-level command first then recursively checking the subcommands for the org value.

Thanks! This surprises me, but it seems that we're hitting clap-rs/clap#1570. With global(true) the value should just magically appear without changes in get_org. However, due to the bug, you'd have to make those changes.

Would you mind waiting until the upstream issue gets resolved? Otherwise, we'd have to check at every nesting level of subcommands, which seems rather dirty.

[someguynamedmatt]

@jan-auer Oh, yeah, that would be a much better solution. I was wondering why global didn't seem to solve the problem. At least it's a known issue. If that upstream fix fixes this issue, all the better.