fix: Session replay crash when writing the replay (#4186)

* fix: Session replay crash when writing the replay

* Update CHANGELOG.md

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## Unreleased
+
+### Fixes
+
+- Session replay crash when writing the replay (#4186)
+
 ## 8.31.1
 
 ### Fixes

Sources/Swift/Integrations/SessionReplay/SentryOnDemandReplay.swift

@@ -22,6 +22,7 @@ private struct VideoFrames {
 
 enum SentryOnDemandReplayError: Error {
  case cantReadVideoSize
+ case assetWriterNotReady
 }
 
 @objcMembers
@@ -120,7 +121,11 @@ class SentryOnDemandReplay: NSObject, SentryReplayVideoMaker {
  videoWriter.startSession(atSourceTime: .zero)
 
  videoWriterInput.requestMediaDataWhenReady(on: workingQueue.queue) { [weak self] in
- guard let self = self else { return }
+ guard let self = self, videoWriter.status == .writing else {
+ videoWriter.cancelWriting()
+ completion(nil, SentryOnDemandReplayError.assetWriterNotReady)
+ return
+ }
 
  if frameCount < videoFrames.framesPaths.count {
  let imagePath = videoFrames.framesPaths[frameCount]

Tests/SentryTests/Integrations/SessionReplay/SentryOnDemandReplayTests.swift

@@ -137,5 +137,26 @@ class SentryOnDemandReplayTests: XCTestCase {
  XCTAssertEqual(sut.frames.count, 0)
  }
 
+ func testInvalidWriter() {
+ let queue = SentryDispatchQueueWrapper()
+ let sut = SentryOnDemandReplay(outputPath: outputPath.path,
+ workingQueue: queue,
+ dateProvider: dateProvider)
+ let expect = expectation(description: "Video render")
+
+ let start = dateProvider.date()
+ sut.addFrameAsync(image: UIImage.add)
+ dateProvider.advance(by: 1)
+ let end = dateProvider.date()
+
+ try? sut.createVideoWith(beginning: start, end: end, outputFileURL: URL(fileURLWithPath: "/invalidPath/video.mp3")) { _, error in
+ XCTAssertNotNil(error)
+ XCTAssertEqual(error as? SentryOnDemandReplayError, SentryOnDemandReplayError.assetWriterNotReady)
+ expect.fulfill()
+ }
+
+ wait(for: [expect], timeout: 1)
+ }
+
 }
 #endif