fix: Functions without prototype error (#2852)

Functions without prototype error
getsentry · Apr 3, 2023 · 1a08f49 · 1a08f49
1 parent 98a8c16
commit 1a08f49
Show file tree

Hide file tree

Showing 24 changed files with 70 additions and 70 deletions.
diff --git a/Samples/iOS-Swift/PerformanceBenchmarks/SentryProcessInfo.m b/Samples/iOS-Swift/PerformanceBenchmarks/SentryProcessInfo.m
@@ -4,7 +4,7 @@
 #import <unistd.h>
 
 BOOL
-isDebugging()
+isDebugging(void)
 {
     struct kinfo_proc info;
 
@@ -29,7 +29,7 @@
 }
 
 BOOL
-isSimulator()
+isSimulator(void)
 {
     NSOperatingSystemVersion ios9 = { 9, 0, 0 };
     NSProcessInfo *processInfo = [NSProcessInfo processInfo];

diff --git a/Samples/iOS-Swift/iOS-Swift/Tools/SentryBenchmarking.mm b/Samples/iOS-Swift/iOS-Swift/Tools/SentryBenchmarking.mm
@@ -13,7 +13,7 @@
 namespace {
 /// @note: Implementation ported from @c SentryThreadHandle.hpp .
 NSDictionary<NSString *, NSArray<NSNumber *> *> *
-cpuInfoByThread()
+cpuInfoByThread(void)
 {
     const auto dict = [NSMutableDictionary<NSString *, NSArray<NSNumber *> *> dictionary];
     mach_msg_type_number_t count;

diff --git a/Samples/macOS-Swift/macOS-Swift/CppSample.cpp b/Samples/macOS-Swift/macOS-Swift/CppSample.cpp
@@ -2,13 +2,13 @@
 #include <stdexcept>
 
 void
-internalFunction()
+internalFunction(void)
 {
     throw std::invalid_argument("Invalid Argument.");
 }
 
 void
-Sentry::CppSample::throwCPPException()
+Sentry::CppSample::throwCPPException(void)
 {
     internalFunction();
 }
diff --git a/Sources/Sentry/SentrySwizzle.m b/Sources/Sentry/SentrySwizzle.m
@@ -112,7 +112,7 @@ @implementation SentrySwizzle
 }
 
 static NSMutableDictionary<NSValue *, NSMutableSet<Class> *> *
-swizzledClassesDictionary()
+swizzledClassesDictionary(void)
 {
     static NSMutableDictionary *swizzledClasses;
     static dispatch_once_t onceToken;

diff --git a/Sources/Sentry/SentrySysctl.m b/Sources/Sentry/SentrySysctl.m
@@ -18,7 +18,7 @@
  * crashes when enabling the address sanitizer.
  */
 __used __attribute__((constructor(60000))) static void
-sentryModuleInitializationHook()
+sentryModuleInitializationHook(void)
 {
     moduleInitializationTimestamp = [NSDate date];
 }

diff --git a/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor.c b/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor.c
@@ -191,7 +191,7 @@ sentrycrashcm_setActiveMonitors(SentryCrashMonitorType monitorTypes)
 }
 
 SentryCrashMonitorType
-sentrycrashcm_getActiveMonitors()
+sentrycrashcm_getActiveMonitors(void)
 {
     return g_activeMonitors;
 }

diff --git a/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_AppState.c b/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_AppState.c
@@ -196,7 +196,7 @@ addJSONData(const char *const data, const int length, void *const userData)
 // ============================================================================
 
 static double
-getCurentTime()
+getCurentTime(void)
 {
     struct timeval tv;
     gettimeofday(&tv, NULL);
@@ -353,7 +353,7 @@ sentrycrashstate_initialize(const char *const stateFilePath)
 }
 
 bool
-sentrycrashstate_reset()
+sentrycrashstate_reset(void)
 {
     if (g_isEnabled) {
         g_state.sessionsSinceLaunch = 1;
@@ -467,7 +467,7 @@ setEnabled(bool isEnabled)
 }
 
 static bool
-isEnabled()
+isEnabled(void)
 {
     return g_isEnabled;
 }
@@ -494,7 +494,7 @@ addContextualInfoToEvent(SentryCrash_MonitorContext *eventContext)
 }
 
 SentryCrashMonitorAPI *
-sentrycrashcm_appstate_getAPI()
+sentrycrashcm_appstate_getAPI(void)
 {
     static SentryCrashMonitorAPI api = { .setEnabled = setEnabled,
         .isEnabled = isEnabled,

diff --git a/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_CPPException.cpp b/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_CPPException.cpp
@@ -186,7 +186,7 @@ CPPExceptionTerminate(void)
 // ============================================================================
 
 static void
-initialize()
+initialize(void)
 {
     static bool isInitialized = false;
     if (!isInitialized) {
@@ -214,13 +214,13 @@ setEnabled(bool isEnabled)
 }
 
 static bool
-isEnabled()
+isEnabled(void)
 {
     return g_isEnabled;
 }
 
 extern "C" SentryCrashMonitorAPI *
-sentrycrashcm_cppexception_getAPI()
+sentrycrashcm_cppexception_getAPI(void)
 {
     static SentryCrashMonitorAPI api = { .setEnabled = setEnabled, .isEnabled = isEnabled };
     return &api;

diff --git a/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_MachException.c b/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_MachException.c
@@ -409,7 +409,7 @@ handleExceptions(void *const userData)
 // ============================================================================
 
 static void
-uninstallExceptionHandler()
+uninstallExceptionHandler(void)
 {
     SentryCrashLOG_DEBUG("Uninstalling mach exception handler.");
 
@@ -446,7 +446,7 @@ uninstallExceptionHandler()
 }
 
 static bool
-installExceptionHandler()
+installExceptionHandler(void)
 {
     SentryCrashLOG_DEBUG("Installing mach exception handler.");
 
@@ -545,7 +545,7 @@ setEnabled(bool isEnabled)
 }
 
 static bool
-isEnabled()
+isEnabled(void)
 {
     return g_isEnabled;
 }
@@ -563,7 +563,7 @@ addContextualInfoToEvent(struct SentryCrash_MonitorContext *eventContext)
 #endif
 
 SentryCrashMonitorAPI *
-sentrycrashcm_machexception_getAPI()
+sentrycrashcm_machexception_getAPI(void)
 {
     static SentryCrashMonitorAPI api = {
 #if SentryCrashCRASH_HAS_MACH

diff --git a/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_NSException.m b/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_NSException.m
@@ -137,13 +137,13 @@
 }
 
 static bool
-isEnabled()
+isEnabled(void)
 {
     return g_isEnabled;
 }
 
 SentryCrashMonitorAPI *
-sentrycrashcm_nsexception_getAPI()
+sentrycrashcm_nsexception_getAPI(void)
 {
     static SentryCrashMonitorAPI api = { .setEnabled = setEnabled, .isEnabled = isEnabled };
     return &api;

diff --git a/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_Signal.c b/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_Signal.c
@@ -120,7 +120,7 @@ handleSignal(int sigNum, siginfo_t *signalInfo, void *userContext)
 // ============================================================================
 
 static bool
-installSignalHandler()
+installSignalHandler(void)
 {
     SentryCrashLOG_DEBUG("Installing signal handler.");
 
@@ -230,7 +230,7 @@ setEnabled(bool isEnabled)
 }
 
 static bool
-isEnabled()
+isEnabled(void)
 {
     return g_isEnabled;
 }
@@ -247,7 +247,7 @@ addContextualInfoToEvent(struct SentryCrash_MonitorContext *eventContext)
 #endif
 
 SentryCrashMonitorAPI *
-sentrycrashcm_signal_getAPI()
+sentrycrashcm_signal_getAPI(void)
 {
     static SentryCrashMonitorAPI api = {
 #if SentryCrashCRASH_HAS_SIGNAL

diff --git a/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_System.m b/Sources/SentryCrash/Recording/Monitors/SentryCrashMonitor_System.m
@@ -241,7 +241,7 @@
  * @return Executable path.
  */
 static NSString *
-getExecutablePath()
+getExecutablePath(void)
 {
     NSBundle *mainBundle = [NSBundle mainBundle];
     NSDictionary *infoDict = [mainBundle infoDictionary];
@@ -255,7 +255,7 @@
  * @return The UUID.
  */
 static const char *
-getAppUUID()
+getAppUUID(void)
 {
     const char *result = nil;
 
@@ -313,7 +313,7 @@
 }
 
 static const char *
-getCurrentCPUArch()
+getCurrentCPUArch(void)
 {
     const char *result = getCPUArchForCPUType(sentrycrashsysctl_int32ForName("hw.cputype"),
         sentrycrashsysctl_int32ForName("hw.cpusubtype"));
@@ -329,7 +329,7 @@
  * @return YES if the device is jailbroken.
  */
 static bool
-isJailbroken()
+isJailbroken(void)
 {
     return sentrycrashdl_imageNamed("MobileSubstrate", false) != UINT32_MAX;
 }
@@ -339,7 +339,7 @@
  * @return YES if the app was built in debug mode.
  */
 static bool
-isDebugBuild()
+isDebugBuild(void)
 {
 #ifdef DEBUG
     return YES;
@@ -353,7 +353,7 @@
  * @return YES if this is a simulator build.
  */
 static bool
-isSimulatorBuild()
+isSimulatorBuild(void)
 {
 #if TARGET_OS_SIMULATOR
     return YES;
@@ -373,7 +373,7 @@
  * @return App Store receipt for iOS, nil otherwise.
  */
 static NSString *
-getReceiptUrlPath()
+getReceiptUrlPath(void)
 {
 #if SentryCrashCRASH_HOST_IOS
     return [NSBundle mainBundle].appStoreReceiptURL.path;
@@ -388,7 +388,7 @@
  * @return The stringified hex representation of the hash for this device + app.
  */
 static const char *
-getDeviceAndAppHash()
+getDeviceAndAppHash(void)
 {
     NSMutableData *data = nil;
 
@@ -436,7 +436,7 @@
  * @return YES if this is a testing build.
  */
 static bool
-isTestBuild()
+isTestBuild(void)
 {
     return [getReceiptUrlPath().lastPathComponent isEqualToString:@"sandboxReceipt"];
 }
@@ -447,7 +447,7 @@
  * @return YES if there is an app store receipt.
  */
 static bool
-hasAppStoreReceipt()
+hasAppStoreReceipt(void)
 {
     NSString *receiptPath = getReceiptUrlPath();
     if (receiptPath == nil) {
@@ -463,13 +463,13 @@
  * Check if the app has an embdded.mobileprovision file in the bundle.
  */
 static bool
-hasEmbeddedMobileProvision()
+hasEmbeddedMobileProvision(void)
 {
     return [[NSBundle mainBundle] pathForResource:@"embedded" ofType:@"mobileprovision"] != nil;
 }
 
 static const char *
-getBuildType()
+getBuildType(void)
 {
     if (isSimulatorBuild()) {
         return "simulator";
@@ -490,7 +490,7 @@
 }
 
 static bytes
-getTotalStorageSize()
+getTotalStorageSize(void)
 {
     NSNumber *storageSize = [[[NSFileManager defaultManager]
         attributesOfFileSystemForPath:NSHomeDirectory()
@@ -499,7 +499,7 @@
 }
 
 static bytes
-getFreeStorageSize()
+getFreeStorageSize(void)
 {
     NSNumber *storageSize = [[[NSFileManager defaultManager]
         attributesOfFileSystemForPath:NSHomeDirectory()
@@ -518,7 +518,7 @@
 // ============================================================================
 
 static void
-initialize()
+initialize(void)
 {
     static bool isInitialized = false;
     if (!isInitialized) {
@@ -607,7 +607,7 @@
 }
 
 static bool
-isEnabled()
+isEnabled(void)
 {
     return g_isEnabled;
 }
@@ -652,7 +652,7 @@
 }
 
 SentryCrashMonitorAPI *
-sentrycrashcm_system_getAPI()
+sentrycrashcm_system_getAPI(void)
 {
     static SentryCrashMonitorAPI api = { .setEnabled = setEnabled,
         .isEnabled = isEnabled,

diff --git a/Sources/SentryCrash/Recording/SentryCrash.m b/Sources/SentryCrash/Recording/SentryCrash.m
@@ -64,7 +64,7 @@
 @end
 
 static NSString *
-getBundleName()
+getBundleName(void)
 {
     NSString *bundleName = [[[NSBundle mainBundle] infoDictionary] objectForKey:@"CFBundleName"];
     if (bundleName == nil) {
@@ -74,7 +74,7 @@
 }
 
 static NSString *
-getBasePath()
+getBasePath(void)
 {
     NSArray *directories
         = NSSearchPathForDirectoriesInDomains(NSCachesDirectory, NSUserDomainMask, YES);