Avoid crashing in SentryCoreDataTracker

Users can pass in a `nil` error parameter when calling Core Data methods like `save:` and `executeFetchRequest:`. We were incorrectly handling that nil error parameter and trying to dereference it inside SENTRY_LOG_DEBUG calls. This commit fixes that.
getsentry · Jul 14, 2023 · 59161ef · 59161ef
1 parent d760c3f
commit 59161ef
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/Sources/Sentry/SentryCoreDataTracker.m b/Sources/Sentry/SentryCoreDataTracker.m
@@ -67,7 +67,7 @@ - (NSArray *)managedObjectContext:(NSManagedObjectContext *)context
  finishWithStatus:result == nil ? kSentrySpanStatusInternalError : kSentrySpanStatusOk];
 
  SENTRY_LOG_DEBUG(@"SentryCoreDataTracker automatically finished span with status: %@",
- error == nil ? @"ok" : @"error");
+ result == nil ? @"error" : @"ok");
  }
 
  return result;
@@ -109,7 +109,7 @@ - (BOOL)managedObjectContext:(NSManagedObjectContext *)context
  [fetchSpan finishWithStatus:result ? kSentrySpanStatusOk : kSentrySpanStatusInternalError];
 
  SENTRY_LOG_DEBUG(@"SentryCoreDataTracker automatically finished span with status: %@",
- *error == nil ? @"ok" : @"error");
+ result ? @"ok" : @"error");
  }
 
  return result;