Rename done

getsentry · Nov 18, 2022 · a8e7397 · a8e7397
1 parent 01a644f
commit a8e7397
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,8 +5,8 @@
 ### Breaking Changes
 
 - Removed `- [SentryOptions initWithDict:didFailWithError:]` (#2404)
-- Removed `- [SentrySDK startWithOptions:]` (#2404)
-- Removed deprecated `- [SentryOptions sdkInfo]` (#2404)
+- Renamed `- [SentrySDK startWithOptionsObject:]` to `- [SentrySDK startWithOptions:]` (#2404)
+- Removed `- [SentryOptions sdkInfo]` (#2404)
 
 ### Fixes
 

diff --git a/Sources/Sentry/Public/SentrySDK.h b/Sources/Sentry/Public/SentrySDK.h
@@ -26,9 +26,10 @@ SENTRY_NO_INIT
 @property (class, nonatomic, readonly) BOOL isEnabled;
 
 /**
- * Inits and configures Sentry (SentryHub, SentryClient) and sets up all integrations.
+ * Inits and configures Sentry (SentryHub, SentryClient) and sets up all integrations. Make sure to
+ * set a valid DSN.
  */
-+ (void)startWithOptionsObject:(SentryOptions *)options NS_SWIFT_NAME(start(options:));
++ (void)startWithOptions:(SentryOptions *)options NS_SWIFT_NAME(start(options:));
 
 /**
  * Inits and configures Sentry (SentryHub, SentryClient) and sets up all integrations. Make sure to

diff --git a/Sources/Sentry/SentrySDK.m b/Sources/Sentry/SentrySDK.m
@@ -128,7 +128,7 @@ + (void)setStartInvocations:(NSUInteger)value
  startInvocations = value;
 }
 
-+ (void)startWithOptionsObject:(SentryOptions *)options
++ (void)startWithOptions:(SentryOptions *)options
 {
  startInvocations++;
 
@@ -149,7 +149,7 @@ + (void)startWithConfigureOptions:(void (^)(SentryOptions *options))configureOpt
 {
  SentryOptions *options = [[SentryOptions alloc] init];
  configureOptions(options);
- [SentrySDK startWithOptionsObject:options];
+ [SentrySDK startWithOptions:options];
 }
 
 + (void)captureCrashEvent:(SentryEvent *)event

diff --git a/Tests/SentryTests/TestUtils/SentryTestObserver.m b/Tests/SentryTests/TestUtils/SentryTestObserver.m
@@ -48,7 +48,7 @@ - (instancetype)init
 
  // The SentryCrashIntegration enriches the scope. We need to install the integration
  // once to get the scope data.
- [SentrySDK startWithOptionsObject:options];
+ [SentrySDK startWithOptions:options];
 
  self.scope = [[SentryScope alloc] init];
  [SentryCrashIntegration enrichScope:self.scope