ci: fix caching in some CI jobs (#2479)

* run the job when trendingmovies sources change or public sentry headers change * fix: cache keys pointing to hashes of files at invalid paths
getsentry · Dec 2, 2022 · b9c9598 · b9c9598
1 parent dd2e101
commit b9c9598
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.github/workflows/benchmarking.yml b/.github/workflows/benchmarking.yml
@@ -38,7 +38,7 @@ jobs:
  path: |
  DerivedData/Build/Products/Debug-iphoneos/iOS-Swift.app.dSYM
  DerivedData/Build/Products/Debug-iphoneos/iOS-Swift.app
- key: ios-swift-for-ui-testing-cache-key-${{ hashFiles('Samples/iOS-Swift/iOS-Swift/**') }}-${{ hashFiles('Sentry/Sources/**') }}
+ key: ios-swift-for-ui-testing-cache-key-${{ hashFiles('Samples/iOS-Swift/iOS-Swift/**') }}-${{ hashFiles('Sources/Sentry/**') }}
  - name: Cache iOS-Swift UI Test Runner App build product
  id: ios-swift-benchmark-runner-cache
  uses: actions/cache@v3

diff --git a/.github/workflows/profile-data-generator.yml b/.github/workflows/profile-data-generator.yml
@@ -4,6 +4,10 @@ name: Generate Profiling Test Data
 on:
  schedule:
  - cron: '0 */6 * * *' # every 6 hours = 4x/day
+ pull_request:
+ paths:
+ - 'Sources/Sentry/Public/**'
+ - 'Samples/TrendingMovies/**'
 
 jobs:
  build-profile-data-generator-targets:
@@ -30,7 +34,7 @@ jobs:
  path: |
  DerivedData/Build/Products/Debug-iphoneos/TrendingMovies.app
  DerivedData/Build/Products/Debug-iphoneos/TrendingMovies.app.dSYM
- key: trendingmovies-app-cache-key-${{ hashFiles('Samples/TrendingMovies/TrendingMovies/**') }}-${{ hashFiles('Sentry/Sources/**') }}
+ key: trendingmovies-app-cache-key-${{ hashFiles('Samples/TrendingMovies/TrendingMovies/**') }}-${{ hashFiles('Sources/Sentry/**') }}
  - name: Cache ProfileDataGenerator UI Test Runner App build product
  id: cache-profiledatagenerator-test-runner-app
  uses: actions/cache@v3

diff --git a/.github/workflows/saucelabs-UI-tests.yml b/.github/workflows/saucelabs-UI-tests.yml
@@ -45,7 +45,7 @@ jobs:
  path: |
  DerivedData/Build/Products/Debug-iphoneos/iOS-Swift.app.dSYM
  DerivedData/Build/Products/Debug-iphoneos/iOS-Swift.app
- key: ios-swift-for-ui-testing-cache-key-${{ hashFiles('Samples/iOS-Swift/iOS-Swift/**') }}-Xcode-${{ matrix.xcode }}-${{ hashFiles('Sentry/Sources/**') }}
+ key: ios-swift-for-ui-testing-cache-key-${{ hashFiles('Samples/iOS-Swift/iOS-Swift/**') }}-Xcode-${{ matrix.xcode }}-${{ hashFiles('Sources/Sentry/**') }}
  - name: Cache iOS-Swift UI Test Runner App build product
  id: ios-swift-uitest-runner-cache
  uses: actions/cache@v3