Skip to content

Commit bd2afd9

Browse files
armcknightarmcknight
authored
ci: deduplicate xcframework builds (#5448)
1 parent f44d106 commit bd2afd9

File tree

3 files changed

+59
-93
lines changed

3 files changed

+59
-93
lines changed

‎.github/workflows/benchmarking.yml‎

Lines changed: 0 additions & 66 deletions
Original file line numberDiff line numberDiff line change
@@ -171,69 +171,3 @@ jobs:
171171
--config .sauce/benchmarking-config.yml \
172172
--tags benchmark \
173173
--verbose
174-
175-
build-xcframework-variant-slices:
176-
uses: ./.github/workflows/build-xcframework-variant-slices.yml
177-
with:
178-
name: Sentry
179-
suffix: "-Dynamic"
180-
variant-id: sentry-dynamic
181-
sdk-list: '["iphoneos", "iphonesimulator"]'
182-
183-
assemble-xcframework-variant:
184-
needs: build-xcframework-variant-slices
185-
uses: ./.github/workflows/assemble-xcframework-variant.yml
186-
with:
187-
name: Sentry
188-
suffix: "-Dynamic"
189-
variant-id: sentry-dynamic
190-
sdks: "iphoneos,iphonesimulator"
191-
192-
app-metrics:
193-
name: Collect app metrics
194-
runs-on: macos-15
195-
needs: assemble-xcframework-variant
196-
steps:
197-
- name: Git checkout
198-
uses: actions/checkout@v4
199-
- run: ./scripts/ci-select-xcode.sh 16.3
200-
- uses: ruby/setup-ruby@v1
201-
with:
202-
bundler-cache: true
203-
- uses: actions/cache@v4
204-
id: app-plain-cache
205-
with:
206-
path: Tests/Perf/test-app-plain.ipa
207-
key: ${{ github.workflow }}-${{ github.job }}-appplain-${{ hashFiles('fastlane/Fastfile', 'Tests/Perf/test-app-plain/**') }}
208-
- name: Build test app plain
209-
if: steps.app-plain-cache.outputs['cache-hit'] != 'true'
210-
run: bundle exec fastlane build_perf_test_app_plain
211-
env:
212-
APP_STORE_CONNECT_KEY_ID: ${{ secrets.APP_STORE_CONNECT_KEY_ID }}
213-
APP_STORE_CONNECT_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_ISSUER_ID }}
214-
APP_STORE_CONNECT_KEY: ${{ secrets.APP_STORE_CONNECT_KEY }}
215-
FASTLANE_KEYCHAIN_PASSWORD: ${{ secrets.FASTLANE_KEYCHAIN_PASSWORD }}
216-
MATCH_GIT_PRIVATE_KEY: ${{ secrets.MATCH_GIT_PRIVATE_KEY }}
217-
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
218-
MATCH_USERNAME: ${{ secrets.MATCH_USERNAME }}
219-
- uses: actions/download-artifact@v4
220-
with:
221-
pattern: xcframework-${{github.sha}}-sentry-dynamic
222-
path: Carthage/
223-
- run: find Carthage -name "Sentry-Dynamic.xcframework.zip" -print0 | xargs -t0I @ unzip @ -d Carthage
224-
- name: Build test app with sentry
225-
run: bundle exec fastlane build_perf_test_app_sentry
226-
env:
227-
APP_STORE_CONNECT_KEY_ID: ${{ secrets.APP_STORE_CONNECT_KEY_ID }}
228-
APP_STORE_CONNECT_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_ISSUER_ID }}
229-
APP_STORE_CONNECT_KEY: ${{ secrets.APP_STORE_CONNECT_KEY }}
230-
FASTLANE_KEYCHAIN_PASSWORD: ${{ secrets.FASTLANE_KEYCHAIN_PASSWORD }}
231-
MATCH_GIT_PRIVATE_KEY: ${{ secrets.MATCH_GIT_PRIVATE_KEY }}
232-
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
233-
MATCH_USERNAME: ${{ secrets.MATCH_USERNAME }}
234-
- name: Collect app metrics
235-
uses: getsentry/action-app-sdk-overhead-metrics@v1
236-
with:
237-
config: Tests/Perf/metrics-test.yml
238-
sauce-user: ${{ secrets.SAUCE_USERNAME }}
239-
sauce-key: ${{ secrets.SAUCE_ACCESS_KEY }}

‎.github/workflows/release.yml‎

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,65 @@ jobs:
172172
shell: bash
173173
- run: swift build
174174

175+
duplication-tests:
176+
name: UI Tests for project with Sentry duplicated - V4 # Up the version with every change to keep track of flaky tests
177+
uses: ./.github/workflows/ui-tests-common.yml
178+
needs: assemble-xcframework-variant
179+
with:
180+
fastlane_command: duplication_test
181+
xcode_version: 16.4
182+
macos_version: macos-15
183+
needs_xcframework: true
184+
185+
app-metrics:
186+
name: Collect app metrics
187+
runs-on: macos-15
188+
needs: assemble-xcframework-variant
189+
steps:
190+
- name: Git checkout
191+
uses: actions/checkout@v4
192+
- run: ./scripts/ci-select-xcode.sh 16.3
193+
- uses: ruby/setup-ruby@v1
194+
with:
195+
bundler-cache: true
196+
- uses: actions/cache@v4
197+
id: app-plain-cache
198+
with:
199+
path: Tests/Perf/test-app-plain.ipa
200+
key: ${{ github.workflow }}-${{ github.job }}-appplain-${{ hashFiles('fastlane/Fastfile', 'Tests/Perf/test-app-plain/**') }}
201+
- name: Build test app plain
202+
if: steps.app-plain-cache.outputs['cache-hit'] != 'true'
203+
run: bundle exec fastlane build_perf_test_app_plain
204+
env:
205+
APP_STORE_CONNECT_KEY_ID: ${{ secrets.APP_STORE_CONNECT_KEY_ID }}
206+
APP_STORE_CONNECT_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_ISSUER_ID }}
207+
APP_STORE_CONNECT_KEY: ${{ secrets.APP_STORE_CONNECT_KEY }}
208+
FASTLANE_KEYCHAIN_PASSWORD: ${{ secrets.FASTLANE_KEYCHAIN_PASSWORD }}
209+
MATCH_GIT_PRIVATE_KEY: ${{ secrets.MATCH_GIT_PRIVATE_KEY }}
210+
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
211+
MATCH_USERNAME: ${{ secrets.MATCH_USERNAME }}
212+
- uses: actions/download-artifact@v4
213+
with:
214+
pattern: xcframework-${{github.sha}}-sentry-dynamic
215+
path: Carthage/
216+
- run: find Carthage -name "Sentry-Dynamic.xcframework.zip" -print0 | xargs -t0I @ unzip @ -d Carthage
217+
- name: Build test app with sentry
218+
run: bundle exec fastlane build_perf_test_app_sentry
219+
env:
220+
APP_STORE_CONNECT_KEY_ID: ${{ secrets.APP_STORE_CONNECT_KEY_ID }}
221+
APP_STORE_CONNECT_ISSUER_ID: ${{ secrets.APP_STORE_CONNECT_ISSUER_ID }}
222+
APP_STORE_CONNECT_KEY: ${{ secrets.APP_STORE_CONNECT_KEY }}
223+
FASTLANE_KEYCHAIN_PASSWORD: ${{ secrets.FASTLANE_KEYCHAIN_PASSWORD }}
224+
MATCH_GIT_PRIVATE_KEY: ${{ secrets.MATCH_GIT_PRIVATE_KEY }}
225+
MATCH_PASSWORD: ${{ secrets.MATCH_PASSWORD }}
226+
MATCH_USERNAME: ${{ secrets.MATCH_USERNAME }}
227+
- name: Collect app metrics
228+
uses: getsentry/action-app-sdk-overhead-metrics@v1
229+
with:
230+
config: Tests/Perf/metrics-test.yml
231+
sauce-user: ${{ secrets.SAUCE_USERNAME }}
232+
sauce-key: ${{ secrets.SAUCE_ACCESS_KEY }}
233+
175234
job_release:
176235
runs-on: ubuntu-latest
177236
name: "Release a new version"

‎.github/workflows/ui-tests.yml‎

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -83,30 +83,3 @@ jobs:
8383
xcode_version: 16.2
8484
build_with_make: true
8585
macos_version: macos-15
86-
87-
build-xcframework-variant-slices:
88-
uses: ./.github/workflows/build-xcframework-variant-slices.yml
89-
with:
90-
name: Sentry
91-
macho-type: staticlib
92-
variant-id: sentry-static-uitests
93-
sdk-list: '["iphoneos", "iphonesimulator"]'
94-
95-
assemble-xcframework-variant:
96-
needs: build-xcframework-variant-slices
97-
uses: ./.github/workflows/assemble-xcframework-variant.yml
98-
secrets: inherit
99-
with:
100-
name: Sentry
101-
variant-id: sentry-static-uitests
102-
sdks: "iphoneos,iphonesimulator"
103-
104-
duplication-tests:
105-
name: UI Tests for project with Sentry duplicated - V4 # Up the version with every change to keep track of flaky tests
106-
uses: ./.github/workflows/ui-tests-common.yml
107-
needs: assemble-xcframework-variant
108-
with:
109-
fastlane_command: duplication_test
110-
xcode_version: 16.4
111-
macos_version: macos-15
112-
needs_xcframework: true

0 commit comments

Comments
 (0)