Skip to content

Conversation

@armcknight
Copy link
Member

@armcknight armcknight commented Jun 20, 2025

We build some form of xcframework in multiple workflows, which is redundant work and wasted compute. Because GitHub Actions doesn't support dependencies between workflows, this places any step that needs an XCFramework into the release.yml workflow where they're already built.

#skip-changelog

Copy link
Member

@philprime philprime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release.yml starts to feel kind of polluted with tests now also being in there, but I agree with the value of deduplication in doing it this way.

@armcknight
Copy link
Member Author

Yeah I'm not really sure what to do with the release.yml growth :/ Maybe there's some further way we can reorganize the jobs/steps into reusable actions like "release-build", "release-validate" and "release-deploy".

@armcknight armcknight merged commit bd2afd9 into main Jun 23, 2025
20 of 23 checks passed
@armcknight armcknight deleted the armcknight/ci/move-duplication-test branch June 23, 2025 18:54
@armcknight
Copy link
Member Author

armcknight commented Jun 23, 2025

Oh apparently there is some facility for workflow dependency: https://stackoverflow.com/a/64733705 and https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#workflow_run

ETA: ofc there is a big caveat that kills it for us:

This event will only trigger a workflow run if the workflow file exists on the default branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants