fix: Fixed flaky testTimezoneChangeNotificationBreadcrumb (#2335)

getsentry · Nov 2, 2022 · bdfccaa · bdfccaa
1 parent 4e037c4
commit bdfccaa
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/Sentry.xcodeproj/xcshareddata/xcschemes/Sentry.xcscheme b/Sentry.xcodeproj/xcshareddata/xcschemes/Sentry.xcscheme
@@ -85,9 +85,6 @@
  <Test
  Identifier = "SentryStacktraceBuilderTests/testAsyncStacktraces_disabled()">
  </Test>
- <Test
- Identifier = "SentrySystemEventBreadcrumbsTest/testTimezoneChangeNotificationBreadcrumb_disabled()">
- </Test>
  </SkippedTests>
  </TestableReference>
  </Testables>

diff --git a/Sources/Sentry/include/SentrySystemEventBreadcrumbs.h b/Sources/Sentry/include/SentrySystemEventBreadcrumbs.h
@@ -16,6 +16,7 @@ SENTRY_NO_INIT
 
 #if TARGET_OS_IOS
 - (void)start:(UIDevice *)currentDevice;
+- (void)timezoneEventTriggered;
 #endif
 
 - (void)stop;

diff --git a/Tests/SentryTests/Integrations/Breadcrumbs/SentrySystemEventBreadcrumbsTest.swift b/Tests/SentryTests/Integrations/Breadcrumbs/SentrySystemEventBreadcrumbsTest.swift
@@ -252,13 +252,14 @@ class SentrySystemEventBreadcrumbsTest: XCTestCase {
  }
  }
 
- func testTimezoneChangeNotificationBreadcrumb_disabled() {
+ func testTimezoneChangeNotificationBreadcrumb() {
  let scope = Scope()
  sut = fixture.getSut(scope: scope, currentDevice: nil)
 
  fixture.currentDateProvider.timezoneOffsetValue = 7_200
 
- NotificationCenter.default.post(Notification(name: NSNotification.Name.NSSystemTimeZoneDidChange))
+ sut.timezoneEventTriggered()
+
  assertBreadcrumbAction(scope: scope, action: "TIMEZONE_CHANGE") { data in
  XCTAssertEqual(data["previous_seconds_from_gmt"] as? Int, 0)
  XCTAssertEqual(data["current_seconds_from_gmt"] as? Int, 7_200)