Skip to content

Commit

Permalink
add new discard reason for insufficient data
Browse files Browse the repository at this point in the history
  • Loading branch information
armcknight committed Jun 27, 2023
1 parent 8ee7f08 commit c6bcf82
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 2 deletions.
3 changes: 3 additions & 0 deletions Sources/Sentry/SentryDiscardReasonMapper.m
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
NSString *const kSentryDiscardReasonNameQueueOverflow = @"queue_overflow";
NSString *const kSentryDiscardReasonNameCacheOverflow = @"cache_overflow";
NSString *const kSentryDiscardReasonNameRateLimitBackoff = @"ratelimit_backoff";
NSString *const kSentryDiscardReasonNameInsufficientData = @"insufficient_data";

NSString *_Nonnull nameForSentryDiscardReason(SentryDiscardReason reason)
{
Expand All @@ -25,5 +26,7 @@
return kSentryDiscardReasonNameCacheOverflow;
case kSentryDiscardReasonRateLimitBackoff:
return kSentryDiscardReasonNameRateLimitBackoff;
case kSentryDiscardReasonInsufficientData:
return kSentryDiscardReasonNameInsufficientData;
}
}
5 changes: 3 additions & 2 deletions Sources/Sentry/include/SentryDiscardReason.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,11 @@ typedef NS_ENUM(NSUInteger, SentryDiscardReason) {
kSentryDiscardReasonNetworkError = 3,
kSentryDiscardReasonQueueOverflow = 4,
kSentryDiscardReasonCacheOverflow = 5,
kSentryDiscardReasonRateLimitBackoff = 6
kSentryDiscardReasonRateLimitBackoff = 6,
kSentryDiscardReasonInsufficientData = 7
};

static DEPRECATED_MSG_ATTRIBUTE(
"Use nameForSentryDiscardReason() instead.") NSString *_Nonnull const SentryDiscardReasonNames[]
= { @"before_send", @"event_processor", @"sample_rate", @"network_error", @"queue_overflow",
@"cache_overflow", @"ratelimit_backoff" };
@"cache_overflow", @"ratelimit_backoff", @"insufficient_data" };
1 change: 1 addition & 0 deletions Sources/Sentry/include/SentryDiscardReasonMapper.h
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ FOUNDATION_EXPORT NSString *const kSentryDiscardReasonNameNetworkError;
FOUNDATION_EXPORT NSString *const kSentryDiscardReasonNameQueueOverflow;
FOUNDATION_EXPORT NSString *const kSentryDiscardReasonNameCacheOverflow;
FOUNDATION_EXPORT NSString *const kSentryDiscardReasonNameRateLimitBackoff;
FOUNDATION_EXPORT NSString *const kSentryDiscardReasonNameInsufficientData;

NSString *nameForSentryDiscardReason(SentryDiscardReason reason);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,6 @@ class SentryDiscardReasonMapperTests: XCTestCase {
XCTAssertEqual(kSentryDiscardReasonNameQueueOverflow, nameForSentryDiscardReason(.queueOverflow))
XCTAssertEqual(kSentryDiscardReasonNameCacheOverflow, nameForSentryDiscardReason(.cacheOverflow))
XCTAssertEqual(kSentryDiscardReasonNameRateLimitBackoff, nameForSentryDiscardReason(.rateLimitBackoff))
XCTAssertEqual(kSentryDiscardReasonNameInsufficientData, nameForSentryDiscardReason(.insufficientData))
}
}

0 comments on commit c6bcf82

Please sign in to comment.