Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return NoOpSpan when starting a child on a finished transaction #1624

Closed
philipphofmann opened this issue Jan 12, 2022 · 1 comment · Fixed by #2239
Closed

Return NoOpSpan when starting a child on a finished transaction #1624

philipphofmann opened this issue Jan 12, 2022 · 1 comment · Fixed by #2239
Assignees
@kevinrenskers
Labels
Platform: Cocoa Type: Feature Request

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Jan 12, 2022 •
edited by kevinrenskers
Loading

Problem Statement

Related to getsentry/sentry-java#1840

Solution Brainstorm

After calling finish, the transaction should return a NoOpSpan when starting a new child span, and log a message that the SDK is not sending the span to Sentry.
@github-actions
Copy link

github-actions bot commented Feb 2, 2022

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Backlog or Status: In Progress, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@github-actions github-actions bot closed this as completed Feb 9, 2022
@brustolin brustolin reopened this Feb 14, 2022
@kevinrenskers kevinrenskers changed the title Return NoOpSpans when transaction finished Return NoOpSpans when starting a child on a finished transaction Sep 28, 2022
@kevinrenskers kevinrenskers changed the title Return NoOpSpans when starting a child on a finished transaction Return NoOpSpan when starting a child on a finished transaction Sep 28, 2022
kevinrenskers added a commit that referenced this issue Sep 29, 2022
@kevinrenskers
fix: Starting a new span on a finished span results in a SentryNoOpSpan
bc605e8 
Closes #1624
@kevinrenskers kevinrenskers mentioned this issue Sep 29, 2022
Merged
5 tasks
kevinrenskers added a commit that referenced this issue Oct 3, 2022
@kevinrenskers
fix: Return SentryNoOpSpan when starting a child on a finished transa…
4a0c282 
…ction (#2239)

* fix: Starting a new span on a finished span results in a SentryNoOpSpan

Closes #1624

* Add a test

* Changelog

* Fix test

* Fix test

* Move changelog

(this is such an annoying manual thing to keep fixing)

* Whoops

* Fix tests (why does this work locally?)

* Clean up

* Use self.tracer.isFinished

* Add testStartGrandChildOnFinishedSpan

* Move logic to SentryTracer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinrenskers kevinrenskers

Labels
Platform: Cocoa Type: Feature Request
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Return SentryNoOpSpan when starting a child on a finished transaction getsentry/sentry-cocoa
4 participants
@kevinrenskers @bruno-garcia @philipphofmann @brustolin