Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SentyCrashIntegration setting screen pixels can get stuck #2284

Closed
philipphofmann opened this issue Oct 13, 2022 · 0 comments · Fixed by #2293
Closed

SentyCrashIntegration setting screen pixels can get stuck #2284

philipphofmann opened this issue Oct 13, 2022 · 0 comments · Fixed by #2293
Assignees

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Oct 13, 2022

Description

The following code gets stuck

#if SENTRY_HAS_UIDEVICE
[deviceData setValue:@(UIScreen.mainScreen.bounds.size.height) forKey:@"screen_height_pixels"];
[deviceData setValue:@(UIScreen.mainScreen.bounds.size.width) forKey:@"screen_width_pixels"];
#endif

when running the TestObserver with test configuration TestCI.

{
[[XCTestObservationCenter sharedTestObservationCenter]
addTestObserver:[[SentryTestObserver alloc] init]];
}

A temporary fix was done with #2285.

Ideally the code in SentryCrashIntegration would ensure that it can safely access UIScreen.mainScreen.

philipphofmann added a commit that referenced this issue Oct 13, 2022
Some tests get stuck on the master branch which uses TestCI
configuration. The code that gets stuck is accessing UIScreen.mainScreen
in SentryCrashIntegration. This is just a workaround, the actual fix will be done
with #2284.
philipphofmann added a commit that referenced this issue Oct 13, 2022
Some tests get stuck on the master branch which uses TestCI
configuration. The code that gets stuck is accessing UIScreen.mainScreen
in SentryCrashIntegration. This is just a workaround, the actual fix will be done
with #2284.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants