-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SentyCrashIntegration setting screen pixels can get stuck #2284
Labels
Comments
philipphofmann
added a commit
that referenced
this issue
Oct 13, 2022
Some tests get stuck on the master branch which uses TestCI configuration. The code that gets stuck is accessing UIScreen.mainScreen in SentryCrashIntegration. This is just a workaround, the actual fix will be done with #2284.
philipphofmann
added a commit
that referenced
this issue
Oct 13, 2022
Some tests get stuck on the master branch which uses TestCI configuration. The code that gets stuck is accessing UIScreen.mainScreen in SentryCrashIntegration. This is just a workaround, the actual fix will be done with #2284.
kevinrenskers
added a commit
that referenced
this issue
Oct 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
The following code gets stuck
sentry-cocoa/Sources/Sentry/SentryCrashIntegration.m
Lines 273 to 276 in 372ffbe
when running the TestObserver with test configuration TestCI.
sentry-cocoa/Tests/SentryTests/TestUtils/SentryTestObserver.m
Lines 32 to 35 in 372ffbe
A temporary fix was done with #2285.
Ideally the code in SentryCrashIntegration would ensure that it can safely access
UIScreen.mainScreen
.The text was updated successfully, but these errors were encountered: