Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rate limiting logs to level warning or error #4456

Open
Tracked by #195
, #4193
...
philipphofmann opened this issue Oct 17, 2024 · 1 comment
Open
Tracked by #195
, #4193
...

Change rate limiting logs to level warning or error #4456

philipphofmann opened this issue Oct 17, 2024 · 1 comment
Labels
Platform: Cocoa Waiting for: Product Owner

Comments

@philipphofmann
Copy link
Member

philipphofmann commented Oct 17, 2024 •
edited
Loading

Description

See getsentry/team-mobile#195.
This was referenced Oct 18, 2024
Open
Open
@rwachtler
Copy link

rwachtler commented Oct 20, 2024 •
edited
Loading

Hey @philipphofmann ! I was wondering if the goal is just to update the log-level here to something like SENTRY_LOG_WARN(@"RateLimit is active for all envelope items.") (as the title of this issue states) or also have some additional log statement, which isn't bound to the condition that all items has to be rate-limited in order to print the log?

I've the first variant ready in a fork, let me know if I should open a PR.

SentryHttpTransportTests
Image

rwachtler added a commit to rwachtler/sentry-cocoa that referenced this issue Oct 20, 2024
@rwachtler
ref(transport): Update rate-limit log level to WARN
18ace11 
Log a warning if all items of the current envelope were rate-limited

Fixes getsentry#4456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Platform: Cocoa Waiting for: Product Owner
Projects
GitHub Issues with 👀 3
Status: Waiting for: Product Owner
Mobile & Cross Platform SDK
Status: Needs Discussion
Milestone
No milestone
Development

No branches or pull requests
2 participants
@philipphofmann @rwachtler