Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SpanProtocol add setData for Swift #1305

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Sep 1, 2021

📜 Description

Swift didn't have a method for SpanProtocol.setData as the Swift name for
setData was setExtra by mistake. This is fixed now by adding an setExtra
for both Objective-C and Swift to avoid a breaking change. setExtra will
be deprecated
and removed in future versions.

💡 Motivation and Context

I came across this issue when looking at the code.

💚 How did you test it?

Unit tests.

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

🔮 Next steps

Swift didn't have a method for SpanProtocol.setData as the Swift name for
setData was setExtra by mistake. This is fixed now by adding an setExtra
for both Objective-C and Swift to avoid a breaking change. setExtra will
be deprecated and removed in future versions.
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2021

Codecov Report

Merging #1305 (c9b238c) into master (524a77d) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1305      +/-   ##
==========================================
+ Coverage   95.47%   95.51%   +0.04%     
==========================================
  Files         149      149              
  Lines        5326     5330       +4     
==========================================
+ Hits         5085     5091       +6     
+ Misses        241      239       -2     
Impacted Files Coverage Δ
Sources/Sentry/SentrySpan.m 100.00% <100.00%> (ø)
Sources/Sentry/SentryTracer.m 98.53% <100.00%> (+0.50%) ⬆️
Sources/Sentry/SentryNetworkTracker.m 99.18% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 524a77d...c9b238c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants