Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix broken Benchmark test #2208

Merged
merged 4 commits into from
Sep 22, 2022
Merged

ci: Fix broken Benchmark test #2208

merged 4 commits into from
Sep 22, 2022

Conversation

kevinrenskers
Copy link
Contributor

@kevinrenskers kevinrenskers commented Sep 22, 2022 •
edited
Loading

The re-enabled Benchmark test doesn't work with automatic code signing which we enabled a little while ago.

Closes #2207

#skip-changelog

@github-actions
Copy link

github-actions bot commented Sep 22, 2022 •
edited
Loading

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.69 ms 1237.88 ms 16.19 ms
Size 20.51 KiB 331.79 KiB 311.28 KiB

Previous results on branch: fix/benchmark-test-fix

Startup times

Revision Plain With Sentry Diff
411731f 1239.71 ms 1276.43 ms 36.71 ms

App size

Revision Plain With Sentry Diff
411731f 20.51 KiB 331.79 KiB 311.28 KiB

@philipphofmann philipphofmann changed the title fix: Fix broken Benchmark test ci: Fix broken Benchmark test Sep 22, 2022
philipphofmann
philipphofmann approved these changes Sep 22, 2022
View reviewed changes
Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@philipphofmann philipphofmann merged commit 9fc2dd0 into master Sep 22, 2022
@philipphofmann philipphofmann deleted the fix/benchmark-test-fix branch September 22, 2022 11:24
kevinrenskers added a commit that referenced this pull request Sep 22, 2022
@kevinrenskers
Merge branch 'master' into fix/bytes-type
9546e20 
* master:
  ci: Remove caching for UI tests (#2210)
  ci: Fix broken Benchmark test (#2208)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipphofmann philipphofmann philipphofmann approved these changes

@brustolin brustolin Awaiting requested review from brustolin

@armcknight armcknight Awaiting requested review from armcknight

@indragiek indragiek Awaiting requested review from indragiek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Benchmark test is broken
2 participants
@kevinrenskers @philipphofmann