Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Clean up unused imports #2244

Merged
merged 5 commits into from
Oct 3, 2022
Merged

ref: Clean up unused imports #2244

merged 5 commits into from
Oct 3, 2022

Conversation

kevinrenskers
Copy link
Contributor

While looking into the OOM implementation I noticed these unused imports.

#skip-changelog

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it compiles, LGTM

@github-actions
Copy link

github-actions bot commented Oct 3, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1243.16 ms 1245.74 ms 2.58 ms
Size 20.51 KiB 333.10 KiB 312.59 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
0fdf0b2 1249.20 ms 1254.08 ms 4.88 ms
864c39a 1226.12 ms 1248.26 ms 22.13 ms
074350f 1241.00 ms 1249.60 ms 8.60 ms
0fdf0b2 1245.88 ms 1247.69 ms 1.82 ms
4a66f00 1224.73 ms 1241.14 ms 16.41 ms
864c39a 1191.14 ms 1233.38 ms 42.24 ms
e958899 1230.40 ms 1248.31 ms 17.91 ms
172c95a 1220.08 ms 1251.74 ms 31.66 ms
0fdf0b2 1266.27 ms 1277.90 ms 11.63 ms
b172a8b 1257.68 ms 1272.38 ms 14.70 ms

App size

Revision Plain With Sentry Diff
0fdf0b2 20.51 KiB 332.90 KiB 312.39 KiB
864c39a 20.51 KiB 335.57 KiB 315.06 KiB
074350f 20.51 KiB 335.52 KiB 315.01 KiB
0fdf0b2 20.51 KiB 332.90 KiB 312.39 KiB
4a66f00 20.51 KiB 331.79 KiB 311.28 KiB
864c39a 20.51 KiB 335.57 KiB 315.06 KiB
e958899 20.51 KiB 331.92 KiB 311.41 KiB
172c95a 20.51 KiB 335.57 KiB 315.06 KiB
0fdf0b2 20.51 KiB 332.90 KiB 312.39 KiB
b172a8b 20.51 KiB 331.79 KiB 311.28 KiB

Previous results on branch: meta/cleanup-imports

Startup times

Revision Plain With Sentry Diff
3cdf2b9 1220.65 ms 1241.48 ms 20.83 ms
a02211f 1216.50 ms 1251.68 ms 35.18 ms
b038dfd 1249.42 ms 1270.70 ms 21.28 ms

App size

Revision Plain With Sentry Diff
3cdf2b9 20.51 KiB 333.10 KiB 312.59 KiB
a02211f 20.51 KiB 333.10 KiB 312.60 KiB
b038dfd 20.51 KiB 333.10 KiB 312.59 KiB

@kevinrenskers kevinrenskers changed the title ref: Clean up unused SentryAppStateManager imports ref: Clean up unused imports Oct 3, 2022
@kevinrenskers kevinrenskers merged commit e2f1150 into master Oct 3, 2022
@kevinrenskers kevinrenskers deleted the meta/cleanup-imports branch October 3, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants