Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SentryCrash writing nan for invalid number #2348

Merged
merged 4 commits into from
Nov 3, 2022
Merged

Conversation

brustolin
Copy link
Contributor

📜 Description

Instead of writing nan (which is invalid for json format) in the crash report for invalid numbers, start writing null.

💡 Motivation and Context

closes #2327

💚 How did you test it?

Unit test

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • Review from the native team if needed
  • No breaking changes

@brustolin brustolin changed the title fix: SentryCrash using nan for invalid number fix: SentryCrash writing nan for invalid number Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1243.18 ms 1261.31 ms 18.12 ms
Size 20.50 KiB 361.86 KiB 341.35 KiB

Baseline results on branch: master

Startup times

Revision Plain With Sentry Diff
202334c 1265.41 ms 1277.34 ms 11.93 ms
604586a 1216.06 ms 1249.10 ms 33.04 ms
3e85a23 1244.94 ms 1265.55 ms 20.61 ms
3861500 1214.88 ms 1232.48 ms 17.60 ms
e43ce74 1235.77 ms 1252.06 ms 16.29 ms
ae4f9dd 1238.88 ms 1247.74 ms 8.86 ms
0fdf0b2 1243.92 ms 1250.86 ms 6.94 ms
c929040 1254.84 ms 1278.42 ms 23.58 ms
64225be 1218.57 ms 1238.38 ms 19.81 ms
d47c2c0 1264.73 ms 1271.88 ms 7.15 ms

App size

Revision Plain With Sentry Diff
202334c 20.51 KiB 331.79 KiB 311.28 KiB
604586a 20.51 KiB 333.15 KiB 312.65 KiB
3e85a23 20.50 KiB 339.00 KiB 318.49 KiB
3861500 20.50 KiB 333.54 KiB 313.04 KiB
e43ce74 20.51 KiB 335.49 KiB 314.99 KiB
ae4f9dd 20.50 KiB 338.99 KiB 318.49 KiB
0fdf0b2 20.51 KiB 332.90 KiB 312.39 KiB
c929040 20.51 KiB 333.10 KiB 312.59 KiB
64225be 20.50 KiB 339.02 KiB 318.51 KiB
d47c2c0 20.50 KiB 342.31 KiB 321.80 KiB

@brustolin brustolin merged commit 7ade7ad into master Nov 3, 2022
@brustolin brustolin deleted the fix/invalid-char branch November 3, 2022 12:25
kevinrenskers added a commit that referenced this pull request Nov 7, 2022
* master:
  test: Delete empty OOMLogicTests (#2361)
  fix: profiling transaction timestamps (#2359)
  fix: profiling transaction thread IDs (#2358)
  test: Use flush for macOS-SPM sample (#2360)
  release: 7.30.0
  fix: SentryCrash writing nan for invalid number (#2348)
  HTTP Client errors (#2308)
  ci: Call make for analyze (#2353)
  fix: CoreData tracking entity name retrieval (#2329)
  fix: sampled profile format backend validation errors (#2350)
  build(deps): bump github/codeql-action from 2.1.29 to 2.1.30 (#2351)
  build(deps): bump github/codeql-action from 2.1.28 to 2.1.29 (#2344)
  fix: Fixed flaky testTimezoneChangeNotificationBreadcrumb (#2335)

# Conflicts:
#	Sentry.xcodeproj/project.pbxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Could not decode report: Invalid character
2 participants