Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Skip delete old envelopes for most tests #2656

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

philipphofmann
Copy link
Member

Deleting old envelope items in the SentryFileManager can cause side effects for tests as it could delete envelope items needed for other tests async. Now the SentryClient runs the deletion in production and we only run the deletion for selected tests.

Came up in https://github.com/getsentry/sentry-cocoa/actions/runs/4013580316

#skip-changelog

Deleting old envelope items in the SentryFileManager can cause side effects for tests
as it could delete envelope items needed for other tests async. Now the SentryClient runs
the deletion in production and we only run the deletion for selected tests.
@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1214.65 ms 1234.40 ms 19.75 ms
Size 20.76 KiB 419.94 KiB 399.18 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e71cf92 1201.69 ms 1226.52 ms 24.83 ms
c6504da 1232.06 ms 1243.28 ms 11.22 ms
fdfe96b 1227.90 ms 1242.56 ms 14.66 ms
15b8c61 1223.16 ms 1244.83 ms 21.67 ms
3f1be0f 1208.12 ms 1225.72 ms 17.60 ms
56ec5d0 1194.39 ms 1236.94 ms 42.55 ms
302ee8b 1194.02 ms 1223.34 ms 29.32 ms
d10ae0c 1250.02 ms 1253.74 ms 3.72 ms
feba2be 1246.67 ms 1254.64 ms 7.97 ms
dc0db9e 1222.10 ms 1240.90 ms 18.80 ms

App size

Revision Plain With Sentry Diff
e71cf92 20.76 KiB 419.85 KiB 399.10 KiB
c6504da 20.76 KiB 414.44 KiB 393.69 KiB
fdfe96b 20.76 KiB 419.70 KiB 398.95 KiB
15b8c61 20.76 KiB 419.67 KiB 398.91 KiB
3f1be0f 20.76 KiB 414.44 KiB 393.69 KiB
56ec5d0 20.76 KiB 414.44 KiB 393.68 KiB
302ee8b 20.76 KiB 419.62 KiB 398.87 KiB
d10ae0c 20.76 KiB 419.86 KiB 399.10 KiB
feba2be 20.76 KiB 414.45 KiB 393.69 KiB
dc0db9e 20.76 KiB 419.62 KiB 398.86 KiB

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #2656 (e5a28b7) into main (e71cf92) will increase coverage by 1.61%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2656      +/-   ##
==========================================
+ Coverage   78.42%   80.04%   +1.61%     
==========================================
  Files         246      246              
  Lines       22844    22863      +19     
  Branches     9898    10099     +201     
==========================================
+ Hits        17916    18300     +384     
+ Misses       4463     4113     -350     
+ Partials      465      450      -15     
Impacted Files Coverage Δ
Sources/Sentry/SentryClient.m 98.45% <100.00%> (+<0.01%) ⬆️
Sources/Sentry/SentryFileManager.m 95.06% <100.00%> (+0.02%) ⬆️
Sources/SentryCrash/Recording/SentryCrashDoctor.m 15.87% <0.00%> (-0.09%) ⬇️
Sources/Sentry/SentryScreenshot.m 73.52% <0.00%> (ø)
Sources/Sentry/NSDictionary+SentrySanitize.m 100.00% <0.00%> (ø)
...yCrash/Recording/Tools/SentryCrashUUIDConversion.c 100.00% <0.00%> (ø)
Sources/Sentry/SentryCrashIntegration.m 98.66% <0.00%> (+0.03%) ⬆️
...rces/SentryCrash/Recording/Tools/SentryCrashObjC.c 54.72% <0.00%> (+0.10%) ⬆️
...SentryCrash/Recording/Tools/SentryCrashJSONCodec.c 83.09% <0.00%> (+0.23%) ⬆️
Sources/Sentry/SentryCrashReportConverter.m 93.92% <0.00%> (+0.25%) ⬆️
... and 32 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e71cf92...e5a28b7. Read the comment docs.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@philipphofmann philipphofmann merged commit ecd9ecd into main Jan 26, 2023
@philipphofmann philipphofmann deleted the test/skip-deleting-old-envelope-items branch January 26, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants