Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: SentryThread change to nullable #2704

Merged
merged 1 commit into from
Feb 20, 2023
Merged

Conversation

philipphofmann
Copy link
Member

Change _Nullable to nullable for SentryThread.

#skip-changelog

Change _Nullable to nullable for SentryThread.
@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Merging #2704 (eb76c31) into main (72c650a) will increase coverage by 1.40%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2704      +/-   ##
==========================================
+ Coverage   79.15%   80.55%   +1.40%     
==========================================
  Files         247      247              
  Lines       22921    22936      +15     
  Branches     9949    10159     +210     
==========================================
+ Hits        18142    18477     +335     
+ Misses       4307     3995     -312     
+ Partials      472      464       -8     
Impacted Files Coverage Δ
Sources/Sentry/SentryTracer.m 97.29% <0.00%> (ø)
Sources/Sentry/SentryScreenshot.m 73.52% <0.00%> (ø)
Sources/Sentry/NSDictionary+SentrySanitize.m 100.00% <0.00%> (ø)
Sources/Sentry/SentryCrashIntegration.m 98.66% <0.00%> (+0.03%) ⬆️
...rces/SentryCrash/Recording/Tools/SentryCrashObjC.c 54.72% <0.00%> (+0.10%) ⬆️
...SentryCrash/Recording/Tools/SentryCrashJSONCodec.c 83.07% <0.00%> (+0.23%) ⬆️
Sources/Sentry/SentryCrashReportConverter.m 93.93% <0.00%> (+0.25%) ⬆️
Sources/SentryCrash/Recording/SentryCrash.m 76.23% <0.00%> (+0.28%) ⬆️
...h/Recording/Monitors/SentryCrashMonitor_AppState.c 80.13% <0.00%> (+0.33%) ⬆️
Sources/Sentry/SentryUIViewControllerSwizzling.m 56.72% <0.00%> (+0.36%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72c650a...eb76c31. Read the comment docs.

@philipphofmann philipphofmann merged commit a91f733 into main Feb 20, 2023
@philipphofmann philipphofmann deleted the ref/nullable-thread branch February 20, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants