-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create User
and Breadcrumb
from map
#2820
Conversation
|
…try/sentry-cocoa into feat/user-and-breadcrumb-from-map # Conflicts: # Sources/Sentry/PrivateSentrySDKOnly.m
…try/sentry-cocoa into feat/user-and-breadcrumb-from-map
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
89b12eb | 1236.02 ms | 1246.63 ms | 10.61 ms |
45d3ca5 | 1238.53 ms | 1263.09 ms | 24.55 ms |
43aa39d | 1239.16 ms | 1270.42 ms | 31.26 ms |
e8b2fb4 | 1230.70 ms | 1242.84 ms | 12.14 ms |
4977fbc | 1231.55 ms | 1239.80 ms | 8.25 ms |
7f691b5 | 1233.94 ms | 1243.80 ms | 9.86 ms |
ea73af6 | 1230.96 ms | 1244.98 ms | 14.02 ms |
25bcc50 | 1233.47 ms | 1234.27 ms | 0.80 ms |
4c00f8c | 1231.62 ms | 1237.76 ms | 6.14 ms |
efb2222 | 1256.44 ms | 1278.90 ms | 22.46 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
89b12eb | 20.76 KiB | 432.88 KiB | 412.11 KiB |
45d3ca5 | 20.76 KiB | 427.54 KiB | 406.78 KiB |
43aa39d | 20.76 KiB | 432.82 KiB | 412.06 KiB |
e8b2fb4 | 20.76 KiB | 427.23 KiB | 406.46 KiB |
4977fbc | 20.76 KiB | 419.86 KiB | 399.10 KiB |
7f691b5 | 20.76 KiB | 420.55 KiB | 399.79 KiB |
ea73af6 | 20.76 KiB | 425.75 KiB | 404.99 KiB |
25bcc50 | 20.76 KiB | 427.22 KiB | 406.46 KiB |
4c00f8c | 20.76 KiB | 419.62 KiB | 398.86 KiB |
efb2222 | 20.76 KiB | 424.45 KiB | 403.69 KiB |
Previous results on branch: feat/user-and-breadcrumb-from-map
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3d27ebf | 1204.04 ms | 1225.50 ms | 21.46 ms |
4b1bd8f | 1232.34 ms | 1251.66 ms | 19.32 ms |
68027d7 | 1209.98 ms | 1232.00 ms | 22.02 ms |
12d47c8 | 1242.31 ms | 1253.18 ms | 10.87 ms |
429242d | 1239.08 ms | 1250.02 ms | 10.94 ms |
2b84441 | 1228.06 ms | 1241.43 ms | 13.37 ms |
f83b263 | 1237.90 ms | 1256.74 ms | 18.84 ms |
e9514a8 | 1230.00 ms | 1257.54 ms | 27.54 ms |
b7526d8 | 1225.58 ms | 1233.20 ms | 7.62 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3d27ebf | 20.76 KiB | 434.14 KiB | 413.38 KiB |
4b1bd8f | 20.76 KiB | 434.63 KiB | 413.87 KiB |
68027d7 | 20.76 KiB | 427.39 KiB | 406.63 KiB |
12d47c8 | 20.76 KiB | 433.01 KiB | 412.25 KiB |
429242d | 20.76 KiB | 433.02 KiB | 412.25 KiB |
2b84441 | 20.76 KiB | 427.31 KiB | 406.54 KiB |
f83b263 | 20.76 KiB | 427.31 KiB | 406.55 KiB |
e9514a8 | 20.76 KiB | 428.67 KiB | 407.91 KiB |
b7526d8 | 20.76 KiB | 427.39 KiB | 406.63 KiB |
…try/sentry-cocoa into feat/user-and-breadcrumb-from-map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First look, a few things I believe should be changed.
@philipphofmann Having trouble to satisfy CI as an import of |
# Conflicts: # Sentry.xcodeproj/project.pbxproj # Tests/SentryTests/Protocol/SentryUserTests.swift
@denrase, I fixed it for you |
Still need to fix other tests not compiling. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple small things from me.
# Conflicts: # Tests/SentryTests/Protocol/SentryBreadcrumbTests.swift # Tests/SentryTests/SentryScopeSwiftTests.swift
@brustolin @armcknight Merged in main and fixed changelog. Think we can merge? |
📜 Description
Expose initialiser to create
User
andBreadcrumb
from dictionary data.💡 Motivation and Context
Relates to getsentry/team-mobile#59
Closes #2687
💚 How did you test it?
Unit tests
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.