ref: convert an sprintf call to snprintf

CHANGELOG.md

@@ -5,6 +5,7 @@
 ### Fixes
 
 - Crash when serializing invalid objects (#2858)
+- Convert remaining usages of `sprintf` to `snprintf` (#2866)
 
 ## 8.4.0
 

Sources/SentryCrash/Recording/SentryCrashReport.c

@@ -913,14 +913,16 @@ writeNotableStackContents(const SentryCrashReportWriter *const writer,
  highAddress = tmp;
  }
  uintptr_t contentsAsPointer;
- char nameBuffer[40];
+#define SENTRY_NAME_BUFFER_SIZE 40
+ char nameBuffer[SENTRY_NAME_BUFFER_SIZE];
  for (uintptr_t address = lowAddress; address < highAddress; address += sizeof(address)) {
  if (sentrycrashmem_copySafely(
  (void *)address, &contentsAsPointer, sizeof(contentsAsPointer))) {
- sprintf(nameBuffer, "stack@%p", (void *)address);
+ snprintf(nameBuffer, SENTRY_NAME_BUFFER_SIZE, "stack@%p", (void *)address);
  writeMemoryContentsIfNotable(writer, nameBuffer, contentsAsPointer);
  }
  }
+#undef SENTRY_NAME_BUFFER_SIZE
 }
 
 #pragma mark Registers

Sources/SentryCrash/Recording/Tools/SentryCrashJSONCodec.c

@@ -342,8 +342,10 @@ sentrycrashjson_addUIntegerElement(
 {
  int result = sentrycrashjson_beginElement(context, name);
  unlikely_if(result != SentryCrashJSON_OK) { return result; }
- char buff[30];
- sprintf(buff, "%" PRIu64, value);
+#define SENTRY_UINT_BUFFER_SIZE 30
+ char buff[SENTRY_UINT_BUFFER_SIZE];
+ snprintf(buff, SENTRY_UINT_BUFFER_SIZE, "%" PRIu64, value);
+#undef SENTRY_UINT_BUFFER_SIZE
  return addJSONData(context, buff, (int)strlen(buff));
 }