Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use new API to fix test compilation error #2867

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Apr 6, 2023

looks like this pr inadvertently broke a test on main: https://github.com/getsentry/sentry-cocoa/actions/runs/4619928851

this other pr added a test using a SentryTracer init that was removed in the other one, but CI wasn't smart enough to rerun in the PR.

This changes to the new API to use for the equivalent initialization.

#skip-changelog

@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #2867 (7fe7ee1) into main (bcd991b) will decrease coverage by 0.04%.
The diff coverage is 95.40%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2867      +/-   ##
==========================================
- Coverage   81.43%   81.40%   -0.04%     
==========================================
  Files         261      262       +1     
  Lines       24390    24363      -27     
  Branches    10814    10817       +3     
==========================================
- Hits        19863    19833      -30     
+ Misses       4023     3916     -107     
- Partials      504      614     +110     
Impacted Files Coverage Δ
Sources/Sentry/SentryTracer.m 96.20% <92.15%> (-0.57%) ⬇️
Sources/Sentry/SentryHub.m 95.87% <100.00%> (-0.19%) ⬇️
Sources/Sentry/SentryPerformanceTracker.m 100.00% <100.00%> (ø)
Sources/Sentry/SentryTracerConfiguration.m 100.00% <100.00%> (ø)
Sources/Sentry/SentryUIEventTracker.m 100.00% <100.00%> (ø)

... and 27 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33b2f51...7fe7ee1. Read the comment docs.

@brustolin brustolin merged commit 4654f66 into main Apr 6, 2023
@brustolin brustolin deleted the armcknight/fix/test-breakage branch April 6, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants