Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: rename SentryProfiler+Private.h to SentryProfilerState.h #3124

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

armcknight
Copy link
Member

This has been throwing me off when trying to sort out some header imports. I don't think it should be called SentryProfiler+Private because it doesn't contain any interface extensions of SentryProfiler, but rather introduces only the new classes SentryProfilerState (and it's mutable counterpart).

#skip-changelog

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #3124 (3373d60) into main (c2ec420) will increase coverage by 0.015%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3124       +/-   ##
=============================================
+ Coverage   89.170%   89.185%   +0.015%     
=============================================
  Files          500       500               
  Lines        53908     53946       +38     
  Branches     19294     19311       +17     
=============================================
+ Hits         48070     48112       +42     
+ Misses        4985      4982        -3     
+ Partials       853       852        -1     
Impacted Files Coverage Δ
Sources/Sentry/SentryProfiler.mm 83.595% <ø> (ø)
Tests/SentryProfilerTests/SentryProfilerTests.mm 98.728% <ø> (ø)

... and 13 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2ec420...3373d60. Read the comment docs.

@armcknight
Copy link
Member Author

The lone test failure is either a flake or a very rare manifestation of the race condition being explored for #3090; in either case it doesn't have bearing on the changes in this PR so I'm not going to bother rerunning.

@armcknight armcknight merged commit 7cd187e into main Jun 27, 2023
@armcknight armcknight deleted the armcknight/ref/rename-sentryprofiler-private-header branch June 27, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants