Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: rename SentryTracerConcurrency -> SentryProfiledTracerConcurrency #3153

Merged
merged 4 commits into from
Jul 17, 2023

Conversation

armcknight
Copy link
Member

It's a more descriptive name, since this only related to tracers with profiles. I wanted to make this change in #3135 but it messed up the diff too much.

#skip-changelog

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Merging #3153 (c7fe72a) into main (d760c3f) will increase coverage by 0.000%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main     #3153   +/-   ##
=========================================
  Coverage   89.133%   89.134%           
=========================================
  Files          502       502           
  Lines        53965     53987   +22     
  Branches     19329     19345   +16     
=========================================
+ Hits         48101     48121   +20     
- Misses        5008      5010    +2     
  Partials       856       856           
Impacted Files Coverage Δ
...entry/Profiling/SentryProfiledTracerConcurrency.mm 96.610% <ø> (ø)
Sources/Sentry/SentryProfiler.mm 80.000% <ø> (ø)
Sources/Sentry/SentryTracer.m 96.622% <ø> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d760c3f...c7fe72a. Read the comment docs.

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1194.14 ms 1221.66 ms 27.52 ms
Size 22.84 KiB 403.23 KiB 380.39 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
fc163f5 1219.18 ms 1242.74 ms 23.56 ms
e71cf92 1201.69 ms 1226.52 ms 24.83 ms
3b782cc 1261.67 ms 1272.24 ms 10.57 ms
14a1101 1242.71 ms 1272.02 ms 29.31 ms
fcde045 1197.91 ms 1224.80 ms 26.89 ms
c78683b 1246.71 ms 1258.70 ms 11.99 ms
6c31077 1233.80 ms 1245.34 ms 11.54 ms
cbf6225 1221.73 ms 1251.20 ms 29.47 ms
b9b0f0a 1239.76 ms 1257.68 ms 17.92 ms
ff5c1d8 1236.67 ms 1252.34 ms 15.67 ms

App size

Revision Plain With Sentry Diff
fc163f5 20.76 KiB 436.29 KiB 415.53 KiB
e71cf92 20.76 KiB 419.85 KiB 399.10 KiB
3b782cc 20.76 KiB 432.21 KiB 411.45 KiB
14a1101 20.76 KiB 436.25 KiB 415.49 KiB
fcde045 20.76 KiB 435.26 KiB 414.50 KiB
c78683b 20.76 KiB 435.24 KiB 414.48 KiB
6c31077 22.84 KiB 401.65 KiB 378.81 KiB
cbf6225 20.76 KiB 425.77 KiB 405.00 KiB
b9b0f0a 20.76 KiB 434.94 KiB 414.18 KiB
ff5c1d8 20.76 KiB 430.98 KiB 410.22 KiB

@armcknight armcknight merged commit 06bac56 into main Jul 17, 2023
@armcknight armcknight deleted the armcknight/ref/rename-SentryTracerConcurrency branch July 17, 2023 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants