Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: clean up profilers for discarded transactions #3154

Merged
merged 20 commits into from
Jul 21, 2023
Merged

fix: clean up profilers for discarded transactions #3154

merged 20 commits into from
Jul 21, 2023

Commits on Jul 14, 2023

  1. rename SentryTracerConcurrency -> SentryProfiledTracerConcurrency

    @armcknight
    armcknight committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    cd6d521 View commit details
    Browse the repository at this point in the history

  2. clean up profilers for discarded transactions

    @armcknight
    armcknight committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    352df6a View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2023

  1. also stop a running profiler

    @armcknight
    armcknight committed Jul 15, 2023
    Configuration menu
    Copy the full SHA
    0f5d163 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. only store the count of tracers in bookkeeping, not a set of references

    @armcknight
    armcknight committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    1467d20 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Merge remote-tracking branch 'origin/main' into armcknight/fix/profil… 

    …ing-transaction-bookkeeping-cleanup
    @armcknight
    armcknight committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    b04c3ae View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into armcknight/fix/profil… 

    …ing-transaction-bookkeeping-cleanup
    @armcknight
    armcknight committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e63cddf View commit details
    Browse the repository at this point in the history

  3. just call discard profiler from SentryTracer.dealloc

    @armcknight
    armcknight committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    ea7a894 View commit details
    Browse the repository at this point in the history

  4. stub tests to write

    @armcknight
    armcknight committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    d53dce1 View commit details
    Browse the repository at this point in the history

  5. fixup! stub tests to write

    @armcknight
    armcknight committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    45eed31 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into armcknight/fix/profiling-transaction-bookkee… 

    …ping-cleanup
    @armcknight
    armcknight committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    2e02b79 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'main' into armcknight/fix/profiling-transaction-bookkee… 

    …ping-cleanup
    @armcknight
    armcknight committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    b070216 View commit details
    Browse the repository at this point in the history

  8. fixup! Merge branch 'main' into armcknight/fix/profiling-transaction-… 

    …bookkeeping-cleanup
    @armcknight
    armcknight committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    a36628e View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. fixup! fixup! Merge branch 'main' into armcknight/fix/profiling-trans… 

    …action-bookkeeping-cleanup
    @armcknight
    armcknight committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    5c2add3 View commit details
    Browse the repository at this point in the history

  2. stronger checks

    @armcknight
    armcknight committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    e5092c0 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. add more tests

    @armcknight
    armcknight committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    e452f98 View commit details
    Browse the repository at this point in the history

  2. fix tvos build

    @armcknight
    armcknight committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    8c2ade9 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. dont assert presence of profiler in discard; it may have already been… 

    … finished normally by tracer
    @armcknight
    armcknight committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    097e834 View commit details
    Browse the repository at this point in the history

  2. changelog

    @armcknight
    armcknight committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    95dcedb View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into armcknight/fix/profiling-transaction-bookkee… 

    …ping-cleanup
    @armcknight
    armcknight committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    99ea0bf View commit details
    Browse the repository at this point in the history

  4. fix changelog and test failure

    @armcknight
    armcknight committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    0529a52 View commit details
    Browse the repository at this point in the history