Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove noisy NSLog #3227

Merged
merged 2 commits into from
Aug 17, 2023
Merged

fix: remove noisy NSLog #3227

merged 2 commits into from
Aug 17, 2023

Conversation

armcknight
Copy link
Member

Accidentally left in from #3217

@armcknight armcknight merged commit e24290f into main Aug 17, 2023
53 of 54 checks passed
@armcknight armcknight deleted the armcknight/fix/remove-nslog branch August 17, 2023 01:08
@github-actions
Copy link

github-actions bot commented Aug 17, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1243.61 ms 1252.28 ms 8.67 ms
Size 22.84 KiB 403.51 KiB 380.66 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
98a8c16 1243.33 ms 1257.86 ms 14.53 ms
1bbcb9c 1189.61 ms 1223.50 ms 33.89 ms
7cd187e 1229.02 ms 1233.06 ms 4.04 ms
4c00f8c 1231.62 ms 1237.76 ms 6.14 ms
c78683b 1246.71 ms 1258.70 ms 11.99 ms
ddc9b9a 1210.00 ms 1234.18 ms 24.18 ms
7bc3c0d 1259.74 ms 1268.45 ms 8.71 ms
cd39d58 1203.87 ms 1239.88 ms 36.01 ms
c6773e5 1222.48 ms 1240.02 ms 17.54 ms
ecd9ecd 1215.77 ms 1238.70 ms 22.93 ms

App size

Revision Plain With Sentry Diff
98a8c16 20.76 KiB 431.00 KiB 410.24 KiB
1bbcb9c 20.76 KiB 426.10 KiB 405.34 KiB
7cd187e 20.76 KiB 401.65 KiB 380.89 KiB
4c00f8c 20.76 KiB 419.62 KiB 398.86 KiB
c78683b 20.76 KiB 435.24 KiB 414.48 KiB
ddc9b9a 20.76 KiB 420.40 KiB 399.64 KiB
7bc3c0d 20.76 KiB 427.35 KiB 406.59 KiB
cd39d58 20.76 KiB 435.26 KiB 414.50 KiB
c6773e5 20.76 KiB 435.25 KiB 414.49 KiB
ecd9ecd 20.76 KiB 420.23 KiB 399.47 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants