Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove duplicate C++ lib for cocoapod #3312

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Sep 27, 2023

📜 Description

Xcode 15 automatically add libc++, we dont need to add it as well.

💡 Motivation and Context

Removes a warning in the app compilation step.

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@brustolin
Copy link
Contributor Author

It seems that Xcode 14 also dont need the references for c++ libs.
I believe its safe to merge this change because Xcode 13 is deprecated.

@brustolin brustolin marked this pull request as ready for review September 27, 2023 09:16
@brustolin brustolin merged commit d8eb419 into main Sep 28, 2023
@brustolin brustolin deleted the fix/remove-duplicate-lib-cocoapod branch September 28, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants