-
-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: invert settings to remove UIKit from respective configs #3348
Conversation
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7bb0873 | 1226.18 ms | 1247.30 ms | 21.12 ms |
630ddf4 | 1216.50 ms | 1235.94 ms | 19.44 ms |
7fb7afb | 1230.12 ms | 1251.04 ms | 20.92 ms |
2cf1b84 | 1221.10 ms | 1230.34 ms | 9.24 ms |
d61b939 | 1238.61 ms | 1240.08 ms | 1.47 ms |
25737cb | 1235.02 ms | 1250.06 ms | 15.04 ms |
4d68229 | 1233.50 ms | 1262.92 ms | 29.42 ms |
1bf8571 | 1215.31 ms | 1232.48 ms | 17.17 ms |
fd6a31c | 1204.73 ms | 1222.34 ms | 17.61 ms |
438e21a | 1237.47 ms | 1255.24 ms | 17.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7bb0873 | 22.85 KiB | 407.09 KiB | 384.24 KiB |
630ddf4 | 20.76 KiB | 432.37 KiB | 411.61 KiB |
7fb7afb | 20.76 KiB | 419.70 KiB | 398.94 KiB |
2cf1b84 | 20.76 KiB | 431.91 KiB | 411.15 KiB |
d61b939 | 22.85 KiB | 407.63 KiB | 384.78 KiB |
25737cb | 20.76 KiB | 436.29 KiB | 415.53 KiB |
4d68229 | 20.76 KiB | 432.34 KiB | 411.58 KiB |
1bf8571 | 20.76 KiB | 437.12 KiB | 416.36 KiB |
fd6a31c | 20.76 KiB | 436.50 KiB | 415.74 KiB |
438e21a | 20.76 KiB | 434.62 KiB | 413.86 KiB |
Codecov Report
@@ Coverage Diff @@
## main #3348 +/- ##
=============================================
- Coverage 89.233% 89.189% -0.044%
=============================================
Files 500 500
Lines 54537 54539 +2
Branches 19581 19580 -1
=============================================
- Hits 48665 48643 -22
- Misses 5006 5030 +24
Partials 866 866 see 12 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- invert settings to remove UIKit from respective configs ([#3348](https://github.com/getsentry/sentry-cocoa/pull/3348)) If none of the above apply, you can opt out of this check by adding |
Fixes #3347 (which reports a problem with #3175)
We can't add an unsafe setting to SPM and have people build pinned to version numbers: https://forums.swift.org/t/override-for-unsafeflags-in-swift-package-manager/45273/2
We'll just flip the way this configuration is defined so that we don't have to set it in the package manager specs. We don't know of anyone that currently needs this feature that uses the specs; we'll cross that bridge when we get to it.
Added checks to CI for configs that should have UIKit as well as their UIKitless counterparts, just to make sure this didn't break in the other direction.
TODO