Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invert settings to remove UIKit from respective configs #3348

Merged
merged 6 commits into from
Oct 18, 2023

Conversation

armcknight
Copy link
Member

@armcknight armcknight commented Oct 18, 2023

Fixes #3347 (which reports a problem with #3175)

We can't add an unsafe setting to SPM and have people build pinned to version numbers: https://forums.swift.org/t/override-for-unsafeflags-in-swift-package-manager/45273/2

We'll just flip the way this configuration is defined so that we don't have to set it in the package manager specs. We don't know of anyone that currently needs this feature that uses the specs; we'll cross that bridge when we get to it.

Added checks to CI for configs that should have UIKit as well as their UIKitless counterparts, just to make sure this didn't break in the other direction.

TODO

  • CI validation of this scenario. Because it needs to use a version pin, we need a way to pin to a version for a release candidate and use that version in the integration. See SPM release candidate check run #3350

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1263.36 ms 1274.36 ms 11.00 ms
Size 22.85 KiB 411.14 KiB 388.29 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
7bb0873 1226.18 ms 1247.30 ms 21.12 ms
630ddf4 1216.50 ms 1235.94 ms 19.44 ms
7fb7afb 1230.12 ms 1251.04 ms 20.92 ms
2cf1b84 1221.10 ms 1230.34 ms 9.24 ms
d61b939 1238.61 ms 1240.08 ms 1.47 ms
25737cb 1235.02 ms 1250.06 ms 15.04 ms
4d68229 1233.50 ms 1262.92 ms 29.42 ms
1bf8571 1215.31 ms 1232.48 ms 17.17 ms
fd6a31c 1204.73 ms 1222.34 ms 17.61 ms
438e21a 1237.47 ms 1255.24 ms 17.77 ms

App size

Revision Plain With Sentry Diff
7bb0873 22.85 KiB 407.09 KiB 384.24 KiB
630ddf4 20.76 KiB 432.37 KiB 411.61 KiB
7fb7afb 20.76 KiB 419.70 KiB 398.94 KiB
2cf1b84 20.76 KiB 431.91 KiB 411.15 KiB
d61b939 22.85 KiB 407.63 KiB 384.78 KiB
25737cb 20.76 KiB 436.29 KiB 415.53 KiB
4d68229 20.76 KiB 432.34 KiB 411.58 KiB
1bf8571 20.76 KiB 437.12 KiB 416.36 KiB
fd6a31c 20.76 KiB 436.50 KiB 415.74 KiB
438e21a 20.76 KiB 434.62 KiB 413.86 KiB

Previous results on branch: armcknight/fix/invert-uikitless-definition

Startup times

Revision Plain With Sentry Diff
e83a02a 1355.29 ms 1378.45 ms 23.16 ms

App size

Revision Plain With Sentry Diff
e83a02a 22.85 KiB 411.14 KiB 388.29 KiB

@armcknight armcknight marked this pull request as ready for review October 18, 2023 22:05
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #3348 (b0c17f4) into main (4bca912) will decrease coverage by 0.044%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #3348       +/-   ##
=============================================
- Coverage   89.233%   89.189%   -0.044%     
=============================================
  Files          500       500               
  Lines        54537     54539        +2     
  Branches     19581     19580        -1     
=============================================
- Hits         48665     48643       -22     
- Misses        5006      5030       +24     
  Partials       866       866               

see 12 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bca912...b0c17f4. Read the comment docs.

@armcknight armcknight merged commit 7672856 into main Oct 18, 2023
75 of 76 checks passed
@armcknight armcknight deleted the armcknight/fix/invert-uikitless-definition branch October 18, 2023 22:33
@github-actions
Copy link

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- invert settings to remove UIKit from respective configs ([#3348](https://github.com/getsentry/sentry-cocoa/pull/3348))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against b0c17f4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsafe build flags in 8.14.0 - cannot build
2 participants