docs: Document DI Strategy #3396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document how we want to use DI in the SDK.
philipphofmann
requested review from
brustolin and
armcknight
as code owners
brustolin
approved these changes
Nov 10, 2023
kahest
approved these changes
Nov 10, 2023
|
@armcknight, sorry, I couldn't wait to hit the merge button. Please have a look at this PR and add a comment if you disagree with what I put in there. I will update the decision as needed. |
armcknight
reviewed
Nov 13, 2023
There was a problem hiding this comment.
Looks good to me, thanks for capturing this @philipphofmann!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document how we want to use DI in the SDK.
#skip-changelog